From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3B9817556; Wed, 19 Jun 2024 14:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718807028; cv=none; b=KVWVO1XFykZ9OXIT/niUg1OHZd3a+DCOopOKUzDM2MeP+47N0teRT/XN4aGZ99h7fFr28J1Od4kaInPgOe57PvZQRwju9u8Hzp8kh24czzDdcKFrlK4WIjQv6YWPNRrkHs3LRn9fOQqohNIwDKpYvsV9KRjWqd48KCnOJlh0xx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718807028; c=relaxed/simple; bh=m/DPhefj6Aj7VUp6cgTM8mW93C8uSqJjtVUZPbpUW8w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J1KwDMGtAZhti+yGVCLdN46Y5hfDFCVZMkQXB1psjIJEhNwLi7MshiWDNezxgtniqwBPFvhO++1kvwzCoFKs8MGVONo1Rai8sxvpSEKE36fkCtn2KW7rbSZf9GgIag6/IEEhXMF8D5jzltxrtFv9vXW6U4Ys8ZWgDDk25r83guU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id D67B368AFE; Wed, 19 Jun 2024 16:23:40 +0200 (CEST) Date: Wed, 19 Jun 2024 16:23:40 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: move features flags into queue_limits v2 Message-ID: <20240619142340.GA32100@lst.de> References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Precedence: bulk X-Mailing-List: linux-bcache@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jun 19, 2024 at 08:21:14AM -0600, Jens Axboe wrote: > Please check for-6.11/block, as I pulled in the changes to the main > block branch and that threw some merge conflicts mostly due to Damien's > changes in for-6.11/block. While fixing those up, I also came across > oddities like: > > (limits->features & limits->features & BLK_FEAT_ZONED)) { > > which don't make much sense and hence I changed them to > > (limits->features & BLK_FEAT_ZONED)) { Yeah. The above is harmless but of course completely pointless.