From: Christoph Hellwig <hch@lst.de>
To: Wouter Verhelst <w@uter.be>
Cc: "Christoph Hellwig" <hch@lst.de>, "Jens Axboe" <axboe@kernel.dk>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Richard Weinberger" <richard@nod.at>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"Ming Lei" <ming.lei@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Alasdair Kergon" <agk@redhat.com>,
"Mike Snitzer" <snitzer@kernel.org>,
"Mikulas Patocka" <mpatocka@redhat.com>,
"Song Liu" <song@kernel.org>, "Yu Kuai" <yukuai3@huawei.com>,
"Vineeth Vijayan" <vneethv@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org,
drbd-dev@lists.linbit.com, nbd@other.debian.org,
linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org,
virtualization@lists.linux.dev, xen-devel@lists.xenproject.org,
linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev,
linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
"Damien Le Moal" <dlemoal@kernel.org>
Subject: Re: [PATCH 14/26] block: move the nonrot flag to queue_limits
Date: Thu, 25 Jul 2024 15:00:08 +0200 [thread overview]
Message-ID: <20240725130008.GA22625@lst.de> (raw)
In-Reply-To: <ZqI4kosy20WkLC2P@pc220518.home.grep.be>
On Thu, Jul 25, 2024 at 01:35:46PM +0200, Wouter Verhelst wrote:
> NBD actually exports a flag for rotational devices; it's defined in
> nbd.h in the NBD userland source as
>
> #define NBD_FLAG_ROTATIONAL (1 << 4) /* Use elevator algorithm - rotational media */
>
> which is passed in the same flags field which also contains the
> NBD_FLAG_SEND_FLUSH and NBD_FLAG_SEND_FUA flags.
>
> Perhaps we might want to look at that flag and set the device to
> rotational if it is specified?
Yes, that sounds good. Can you send a patch?
next prev parent reply other threads:[~2024-07-25 13:00 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 6:04 move features flags into queue_limits v2 Christoph Hellwig
2024-06-17 6:04 ` [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Christoph Hellwig
2024-06-17 7:55 ` Roger Pau Monné
2024-06-17 10:03 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 02/26] sd: remove sd_is_zoned Christoph Hellwig
2024-06-18 1:39 ` Chaitanya Kulkarni
2024-06-17 6:04 ` [PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics Christoph Hellwig
2024-06-17 6:12 ` Damien Le Moal
2024-06-17 10:04 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 04/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd Christoph Hellwig
2024-06-17 6:04 ` [PATCH 05/26] loop: always update discard settings in loop_reconfigure_limits Christoph Hellwig
2024-06-17 6:04 ` [PATCH 06/26] loop: regularize upgrading the block size for direct I/O Christoph Hellwig
2024-06-17 6:13 ` Damien Le Moal
2024-06-17 6:04 ` [PATCH 07/26] loop: also use the default block size from an underlying block device Christoph Hellwig
2024-06-17 6:14 ` Damien Le Moal
2024-06-17 6:04 ` [PATCH 08/26] loop: fold loop_update_rotational into loop_reconfigure_limits Christoph Hellwig
2024-06-17 6:04 ` [PATCH 09/26] virtio_blk: remove virtblk_update_cache_mode Christoph Hellwig
2024-06-18 1:39 ` Chaitanya Kulkarni
2024-06-17 6:04 ` [PATCH 10/26] nbd: move setting the cache control flags to __nbd_set_size Christoph Hellwig
2024-06-17 6:04 ` [PATCH 11/26] block: freeze the queue in queue_attr_store Christoph Hellwig
2024-06-18 1:41 ` Chaitanya Kulkarni
2024-06-17 6:04 ` [PATCH 12/26] block: remove blk_flush_policy Christoph Hellwig
2024-06-18 1:42 ` Chaitanya Kulkarni
2024-06-17 6:04 ` [PATCH 13/26] block: move cache control settings out of queue->flags Christoph Hellwig
2024-06-17 6:23 ` Damien Le Moal
2024-06-17 10:36 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 14/26] block: move the nonrot flag to queue_limits Christoph Hellwig
2024-06-17 10:36 ` Hannes Reinecke
2024-06-19 15:23 ` Simon Fernandez
2024-06-24 17:08 ` Keith Busch
2024-06-24 17:24 ` Christoph Hellwig
2024-07-04 11:11 ` Simon Fernandez
2024-07-25 11:35 ` Wouter Verhelst
2024-07-25 13:00 ` Christoph Hellwig [this message]
2024-06-17 6:04 ` [PATCH 15/26] block: move the add_random " Christoph Hellwig
2024-06-17 10:38 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 16/26] block: move the io_stat flag setting " Christoph Hellwig
2024-06-17 6:25 ` Damien Le Moal
2024-06-17 10:38 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 17/26] block: move the stable_writes flag " Christoph Hellwig
2024-06-17 10:40 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 18/26] block: move the synchronous " Christoph Hellwig
2024-06-17 10:40 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 19/26] block: move the nowait " Christoph Hellwig
2024-06-17 6:26 ` Damien Le Moal
2024-06-17 10:41 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 20/26] block: move the dax " Christoph Hellwig
2024-06-17 10:42 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 21/26] block: move the poll " Christoph Hellwig
2024-06-17 10:42 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 22/26] block: move the zoned flag into the features field Christoph Hellwig
2024-06-17 10:43 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 23/26] block: move the zone_resetall flag to queue_limits Christoph Hellwig
2024-06-17 10:43 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 24/26] block: move the pci_p2pdma " Christoph Hellwig
2024-06-17 10:44 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 25/26] block: move the skip_tagset_quiesce " Christoph Hellwig
2024-06-17 10:45 ` Hannes Reinecke
2024-06-17 6:04 ` [PATCH 26/26] block: move the bounce flag into the features field Christoph Hellwig
2024-06-17 10:45 ` Hannes Reinecke
2024-06-17 14:35 ` Keith Busch
2024-06-19 14:18 ` move features flags into queue_limits v2 Jens Axboe
2024-06-19 14:21 ` Jens Axboe
2024-06-19 14:23 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-06-11 5:19 move features flags into queue_limits Christoph Hellwig
2024-06-11 5:19 ` [PATCH 14/26] block: move the nonrot flag to queue_limits Christoph Hellwig
2024-06-11 8:02 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725130008.GA22625@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=drbd-dev@lists.linbit.com \
--cc=geert@linux-m68k.org \
--cc=jasowang@redhat.com \
--cc=josef@toxicpanda.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=nvdimm@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=vneethv@linux.ibm.com \
--cc=w@uter.be \
--cc=xen-devel@lists.xenproject.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).