Re: Build regressions/improvements in v6.12-rc1

Re: Build regressions/improvements in v6.12-rc1

[Geert Uytterhoeven]

On Mon, 30 Sep 2024, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v6.12-rc1[1] compared to v6.11[2].

> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9852d85ec9d492ebef56dc5f229416c925758edc/ (all 131 configs)
> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/98f7e32f20d28ec452afb208f9cffc08448a2652/ (all 131 configs)
>
>
> *** ERRORS ***
>
> 12 error regressions:
>  + /kisskb/src/fs/bcachefs/backpointers.c: error: 'const struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 504:53
>  + /kisskb/src/fs/bcachefs/bcachefs_format.h: error: 'struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 332:49, 331:49
>  + /kisskb/src/fs/bcachefs/bkey.h: error: 'const struct bkey' has no member named 'bversion':  => 578:48
>  + /kisskb/src/fs/bcachefs/bkey.h: error: 'const struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 558:27, 557:41, 557:27, 558:41
>  + /kisskb/src/fs/bcachefs/bkey.h: error: 'struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 557:41, 558:41
>  + /kisskb/src/fs/bcachefs/bkey_methods.c: error: 'const struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 292:65
>  + /kisskb/src/fs/bcachefs/bkey_methods.h: error: 'const struct bkey' has no member named 'bversion':  => 73:31, 73:18
>  + /kisskb/src/fs/bcachefs/bkey_methods.h: error: 'const struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 73:33, 73:20, 73:47, 73:34
>  + /kisskb/src/fs/bcachefs/bkey_methods.h: error: control reaches end of non-void function [-Werror=return-type]:  => 75:1
>  + /kisskb/src/fs/bcachefs/disk_accounting.h: error: 'const struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 40:28, 40:42, 39:50, 39:43
>  + /kisskb/src/fs/bcachefs/disk_accounting.h: error: 'struct bkey' has no member named 'bversion'; did you mean 'version'?:  => 39:26, 40:10, 39:33, 40:24

All big-endian platforms (fix available, even on a public mailing list ;-)

>  + /kisskb/src/include/linux/err.h: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]:  => 28:49

powerpc-gcc13/ppc64_book3e_allmodconfig

drivers/soc/fsl/qe/qmc.c: In function 'qmc_qe_init_resources':
include/linux/err.h:28:49: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    28 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
       |                                                 ^
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
    77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
       |                                             ^
drivers/soc/fsl/qe/qmc.c:1764:13: note: in expansion of macro 'IS_ERR_VALUE'
  1764 |         if (IS_ERR_VALUE(info)) {
       |             ^~~~~~~~~~~~

IS_ERR_VALUE() is meant for pointers (fix available)

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds

Re: Build regressions/improvements in v6.12-rc1

[Herve Codina]

Hi Geert,

On Mon, 30 Sep 2024 17:11:09 +0200 (CEST)
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> On Mon, 30 Sep 2024, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v6.12-rc1[1] compared to v6.11[2].  

...

 powerpc-gcc13/ppc64_book3e_allmodconfig
> 
> drivers/soc/fsl/qe/qmc.c: In function 'qmc_qe_init_resources':
> include/linux/err.h:28:49: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     28 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
>        |                                                 ^
> include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
>     77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>        |                                             ^
> drivers/soc/fsl/qe/qmc.c:1764:13: note: in expansion of macro 'IS_ERR_VALUE'
>   1764 |         if (IS_ERR_VALUE(info)) {
>        |             ^~~~~~~~~~~~
> 
> IS_ERR_VALUE() is meant for pointers (fix available)

I saw your patch, tested and acked it.
Thanks for the patch.

Hervé