From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: colyli@suse.de, kent.overstreet@linux.dev, msakai@redhat.com,
corbet@lwn.net, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, namhyung@kernel.org, akpm@linux-foundation.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, willy@infradead.org,
jserv@ccns.ncku.edu.tw, linux-kernel@vger.kernel.org,
linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev,
linux-bcachefs@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-doc@vger.kernel.org, Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH v2 00/10] Enhance min heap API with non-inline functions and optimizations
Date: Sun, 20 Oct 2024 12:01:50 +0800 [thread overview]
Message-ID: <20241020040200.939973-1-visitorckw@gmail.com> (raw)
Add non-inline versions of the min heap API functions in lib/min_heap.c
and updates all users outside of kernel/events/core.c to use these
non-inline versions. To mitigate the performance impact of indirect
function calls caused by the non-inline versions of the swap and
compare functions, a builtin swap has been introduced that swaps
elements based on their size. Additionally, it micro-optimizes the
efficiency of the min heap by pre-scaling the counter, following the
same approach as in lib/sort.c. Documentation for the min heap API has
also been added to the core-api section.
Regards,
Kuan-Wei
---
Changes in v2:
- Added a builtin swap to reduce the performance impact of indirect
function calls.
- Cleaned up duplicate min_heap_callbacks in bcachefs.
- Wrapped documentation at 80 columns.
- Updated Example Usage.
- Included documentation explaining that NULL can be passed to the
swp in min_heap_callbacks to use the builtin swap.
v1: https://lore.kernel.org/lkml/20241013184703.659652-1-visitorckw@gmail.com
Kuan-Wei Chiu (10):
lib/min_heap: Introduce non-inline versions of min heap API functions
lib min_heap: Optimize min heap by prescaling counters for better
performance
lib min_heap: Avoid indirect function call by providing default swap
lib/test_min_heap: Update min_heap_callbacks to use default builtin
swap
perf/core: Update min_heap_callbacks to use default builtin swap
dm vdo: Update min_heap_callbacks to use default builtin swap
bcache: Update min_heap_callbacks to use default builtin swap
bcachefs: Clean up duplicate min_heap_callbacks declarations
bcachefs: Update min_heap_callbacks to use default builtin swap
Documentation/core-api: Add min heap API introduction
Documentation/core-api/index.rst | 1 +
Documentation/core-api/min_heap.rst | 300 +++++++++++++++++++++++
drivers/md/bcache/Kconfig | 1 +
drivers/md/bcache/alloc.c | 11 +-
drivers/md/bcache/bset.c | 14 +-
drivers/md/bcache/extents.c | 10 +-
drivers/md/bcache/movinggc.c | 10 +-
drivers/md/dm-vdo/Kconfig | 1 +
drivers/md/dm-vdo/repair.c | 2 +-
drivers/md/dm-vdo/slab-depot.c | 10 +-
fs/bcachefs/Kconfig | 1 +
fs/bcachefs/clock.c | 25 +-
fs/bcachefs/ec.c | 19 +-
include/linux/min_heap.h | 357 ++++++++++++++++++++++------
kernel/events/core.c | 15 +-
lib/Kconfig | 3 +
lib/Kconfig.debug | 1 +
lib/Makefile | 1 +
lib/min_heap.c | 70 ++++++
lib/test_min_heap.c | 16 +-
20 files changed, 694 insertions(+), 174 deletions(-)
create mode 100644 Documentation/core-api/min_heap.rst
create mode 100644 lib/min_heap.c
--
2.34.1
next reply other threads:[~2024-10-20 4:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 4:01 Kuan-Wei Chiu [this message]
2024-10-20 4:01 ` [PATCH v2 01/10] lib/min_heap: Introduce non-inline versions of min heap API functions Kuan-Wei Chiu
2024-11-26 13:27 ` Geert Uytterhoeven
2024-11-27 2:59 ` Kuan-Wei Chiu
2024-11-27 8:04 ` Geert Uytterhoeven
2024-10-20 4:01 ` [PATCH v2 02/10] lib min_heap: Optimize min heap by prescaling counters for better performance Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 03/10] lib min_heap: Avoid indirect function call by providing default swap Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 04/10] lib/test_min_heap: Update min_heap_callbacks to use default builtin swap Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 05/10] perf/core: " Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 06/10] dm vdo: " Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 07/10] bcache: " Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 08/10] bcachefs: Clean up duplicate min_heap_callbacks declarations Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 09/10] bcachefs: Update min_heap_callbacks to use default builtin swap Kuan-Wei Chiu
2024-10-20 4:02 ` [PATCH v2 10/10] Documentation/core-api: Add min heap API introduction Kuan-Wei Chiu
2024-10-28 6:10 ` Bagas Sanjaya
2024-10-21 9:33 ` [PATCH v2 00/10] Enhance min heap API with non-inline functions and optimizations Bagas Sanjaya
2024-10-21 13:47 ` Kuan-Wei Chiu
2024-10-28 5:04 ` Bagas Sanjaya
2024-10-26 12:44 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241020040200.939973-1-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colyli@suse.de \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kan.liang@linux.intel.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).