From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: colyli@suse.de, kent.overstreet@linux.dev, msakai@redhat.com,
corbet@lwn.net, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, namhyung@kernel.org, akpm@linux-foundation.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, willy@infradead.org,
jserv@ccns.ncku.edu.tw, linux-kernel@vger.kernel.org,
linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev,
linux-bcachefs@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-doc@vger.kernel.org, Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH v2 06/10] dm vdo: Update min_heap_callbacks to use default builtin swap
Date: Sun, 20 Oct 2024 12:01:56 +0800 [thread overview]
Message-ID: <20241020040200.939973-7-visitorckw@gmail.com> (raw)
In-Reply-To: <20241020040200.939973-1-visitorckw@gmail.com>
Replace the swp function pointer in the min_heap_callbacks of dm-vdo
with NULL, allowing direct usage of the default builtin swap
implementation. This modification simplifies the code and improves
performance by removing unnecessary function indirection.
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
drivers/md/dm-vdo/repair.c | 2 +-
drivers/md/dm-vdo/slab-depot.c | 10 +---------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/md/dm-vdo/repair.c b/drivers/md/dm-vdo/repair.c
index ffff2c999518..8c006fb3afcf 100644
--- a/drivers/md/dm-vdo/repair.c
+++ b/drivers/md/dm-vdo/repair.c
@@ -166,7 +166,7 @@ static void swap_mappings(void *item1, void *item2, void __always_unused *args)
static const struct min_heap_callbacks repair_min_heap = {
.less = mapping_is_less_than,
- .swp = swap_mappings,
+ .swp = NULL,
};
static struct numbered_block_mapping *sort_next_heap_element(struct repair_completion *repair)
diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
index 274f9ccd072f..ccf7b2eac131 100644
--- a/drivers/md/dm-vdo/slab-depot.c
+++ b/drivers/md/dm-vdo/slab-depot.c
@@ -3301,17 +3301,9 @@ static bool slab_status_is_less_than(const void *item1, const void *item2,
return info1->slab_number < info2->slab_number;
}
-static void swap_slab_statuses(void *item1, void *item2, void __always_unused *args)
-{
- struct slab_status *info1 = item1;
- struct slab_status *info2 = item2;
-
- swap(*info1, *info2);
-}
-
static const struct min_heap_callbacks slab_status_min_heap = {
.less = slab_status_is_less_than,
- .swp = swap_slab_statuses,
+ .swp = NULL,
};
/* Inform the slab actor that a action has finished on some slab; used by apply_to_slabs(). */
--
2.34.1
next prev parent reply other threads:[~2024-10-20 4:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 4:01 [PATCH v2 00/10] Enhance min heap API with non-inline functions and optimizations Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 01/10] lib/min_heap: Introduce non-inline versions of min heap API functions Kuan-Wei Chiu
2024-11-26 13:27 ` Geert Uytterhoeven
2024-11-27 2:59 ` Kuan-Wei Chiu
2024-11-27 8:04 ` Geert Uytterhoeven
2024-10-20 4:01 ` [PATCH v2 02/10] lib min_heap: Optimize min heap by prescaling counters for better performance Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 03/10] lib min_heap: Avoid indirect function call by providing default swap Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 04/10] lib/test_min_heap: Update min_heap_callbacks to use default builtin swap Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 05/10] perf/core: " Kuan-Wei Chiu
2024-10-20 4:01 ` Kuan-Wei Chiu [this message]
2024-10-20 4:01 ` [PATCH v2 07/10] bcache: " Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 08/10] bcachefs: Clean up duplicate min_heap_callbacks declarations Kuan-Wei Chiu
2024-10-20 4:01 ` [PATCH v2 09/10] bcachefs: Update min_heap_callbacks to use default builtin swap Kuan-Wei Chiu
2024-10-20 4:02 ` [PATCH v2 10/10] Documentation/core-api: Add min heap API introduction Kuan-Wei Chiu
2024-10-28 6:10 ` Bagas Sanjaya
2024-10-21 9:33 ` [PATCH v2 00/10] Enhance min heap API with non-inline functions and optimizations Bagas Sanjaya
2024-10-21 13:47 ` Kuan-Wei Chiu
2024-10-28 5:04 ` Bagas Sanjaya
2024-10-26 12:44 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241020040200.939973-7-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colyli@suse.de \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kan.liang@linux.intel.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=msakai@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).