public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
	 Stephen Zhang <starzhangzsd@gmail.com>,
	 Kent Overstreet <kent.overstreet@linux.dev>,
	Coly Li <colyli@fnnas.com>,
	 Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	 Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	 linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	 Daniel Wagner <dwagner@suse.de>
Subject: [PATCH blktests v5 2/3] bcache: add bcache/002
Date: Thu, 05 Mar 2026 16:01:45 +0100	[thread overview]
Message-ID: <20260305-bcache-v5-2-04cd4c9080d7@suse.de> (raw)
In-Reply-To: <20260305-bcache-v5-0-04cd4c9080d7@suse.de>

Add test case from Stephen Zhang [1][2], which is

1. Wait for fio to complete (wait $fio_pid)
2. Wait a few seconds for I/O to drain
3. Then check the utilization

If utilization is still > 0% after I/O completes, then there's a real
accounting leak.

[1] https://lore.kernel.org/linux-bcache/CANubcdX7eNbH_bo4-f94DUbdiEbt04Vxy1MPyhm+CZyXB01FuQ@mail.gmail.com/
[2] https://lore.kernel.org/all/CANubcdU92Uv7wNdZH357LLTnfwPouekXNTPSjHnzYzK99-eZ9w@mail.gmail.com

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/bcache/002     | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/bcache/002.out |  2 ++
 2 files changed, 80 insertions(+)

diff --git a/tests/bcache/002 b/tests/bcache/002
new file mode 100755
index 000000000000..a50722ff9e0e
--- /dev/null
+++ b/tests/bcache/002
@@ -0,0 +1,78 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2026 Daniel Wagner, SUSE Labs
+#
+# Test based on Stephen Zhang <starzhangzsd@gmail.com> test case
+# https://lore.kernel.org/linux-bcache/CANubcdX7eNbH_bo4-f94DUbdiEbt04Vxy1MPyhm+CZyXB01FuQ@mail.gmail.com/#t
+#
+# Test bcache for bio leaks in clone
+
+. tests/bcache/rc
+
+DESCRIPTION="test bcache for bio leaks in clone"
+
+requires() {
+	_have_fio
+}
+
+read_ticks() {
+	local bdev_name="$1"
+	local stat_file
+
+	stat_file="/sys/block/${bdev_name}/stat"
+	awk '{print $10}' "$stat_file"
+}
+
+get_utilization() {
+	local bdev_name="$1"
+	local t1 t2
+
+	t1="$(read_ticks ${bdev_name})"
+	sleep 1
+	t2="$(read_ticks ${bdev_name})"
+
+	# (t2 - t1) is the ms busy. Over 1000ms, (delta/10) gives percentage.
+	echo "scale=2; ($t2 - $t1) / 10" | bc
+}
+
+test_device_array() {
+	echo "Running ${TEST_NAME}"
+
+	if [[ ${#TEST_DEV_ARRAY[@]} -lt 2 ]]; then
+		SKIP_REASONS+=("requires at least 2 devices")
+		return 1
+	fi
+
+	_setup_bcache "${TEST_DEV_ARRAY[@]}"
+
+	local -a bcache_nodes
+	local bcache_dev bdev_name fio_pid state
+
+	mapfile -t bcache_nodes < <(_create_bcache \
+				--cache "${TEST_DEV_ARRAY[0]##*/}" \
+				--bdev "${TEST_DEV_ARRAY[1]##*/}" \
+				--writeback)
+
+	bcache_dev="${bcache_nodes[0]}"
+	bdev_name="$(basename "${bcache_dev}")"
+	echo 1 > /sys/block/"${bdev_name}"/bcache/detach
+
+	state="$(cat /sys/block/"${bdev_name}"/bcache/state)"
+	echo "Device state: ${state}"
+
+	_run_fio_rand_io --filename="${bcache_dev}" --time_base \
+			--runtime=10 >> "$FULL" 2>&1 
+	
+	sleep 5
+
+	local util
+	util="$(get_utilization "${bdev_name}")"
+
+	if (( $(echo "${util} > 1.0" | bc --mathlib) )); then
+		echo "ERROR: Accounting leak detected! Current utilization: ${util}%"
+	fi
+
+	_remove_bcache --bcache "${bcache_nodes[@]}" \
+			--cache "${TEST_DEV_ARRAY[0]##*/}" \
+			--bdev "${TEST_DEV_ARRAY[1]##*/}"
+}
diff --git a/tests/bcache/002.out b/tests/bcache/002.out
new file mode 100644
index 000000000000..529c1a90b135
--- /dev/null
+++ b/tests/bcache/002.out
@@ -0,0 +1,2 @@
+Running bcache/002
+Device state: no cache

-- 
2.53.0


  parent reply	other threads:[~2026-03-05 15:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 15:01 [PATCH blktests v5 0/3] bcache: add initial test cases Daniel Wagner
2026-03-05 15:01 ` [PATCH blktests v5 1/3] bcache: add bcache/001 Daniel Wagner
2026-03-06  9:49   ` Johannes Thumshirn
2026-03-06 12:15   ` Shinichiro Kawasaki
2026-03-06 12:45     ` Daniel Wagner
2026-03-05 15:01 ` Daniel Wagner [this message]
2026-03-06  9:59   ` [PATCH blktests v5 2/3] bcache: add bcache/002 Johannes Thumshirn
2026-03-06 12:27   ` Shinichiro Kawasaki
2026-03-06 13:14     ` Daniel Wagner
2026-03-07 10:24       ` Shinichiro Kawasaki
2026-03-10  9:29         ` Stephen Zhang
2026-03-12  1:44           ` Shinichiro Kawasaki
2026-03-05 15:01 ` [PATCH blktests v5 3/3] doc: document how to configure bcache tests Daniel Wagner
2026-03-06 10:00   ` Johannes Thumshirn
2026-03-07 10:27 ` [PATCH blktests v5 0/3] bcache: add initial test cases Shinichiro Kawasaki
2026-03-09  9:40   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305-bcache-v5-2-04cd4c9080d7@suse.de \
    --to=dwagner@suse.de \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=colyli@fnnas.com \
    --cc=hch@infradead.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=starzhangzsd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox