public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: mingzhe.zou@easystack.cn
To: colyli@kernel.org, colyli@fnnas.com
Cc: linux-bcache@vger.kernel.org, zoumingzhe@qq.com,
	zoumingzhe@outlook.com, Mingzhe Zou <mingzhe.zou@easystack.cn>
Subject: [PATCH] bcache: fix uninitialized closure object
Date: Thu,  2 Apr 2026 21:03:53 +0800	[thread overview]
Message-ID: <20260402130353.1099802-1-mingzhe.zou@easystack.cn> (raw)

From: Mingzhe Zou <zoumingzhe@qq.com>

In the previous patch(bcache: fix cached_dev.sb_bio use-after-free and crash),
we adopted a simple modification suggestion from AI to fix the use-after-free.

But in actual testing, we found an extreme case where the device is stopped
before calling bch_write_bdev_super().

At this point, struct closure sb_write has not been initialized yet.

For this patch, we ensure that sb_bio has been completed via sb_write_mutex.

Signed-off-by: Mingzhe Zou <mingzhe.zou@easystack.cn>
---
 drivers/md/bcache/super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 6627a381f65a..97d9adb0bf96 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1378,7 +1378,8 @@ static CLOSURE_CALLBACK(cached_dev_free)
 	 * The sb_bio is embedded in struct cached_dev, so we must
 	 * ensure no I/O is in progress.
 	 */
-	closure_sync(&dc->sb_write);
+	down(&dc->sb_write_mutex);
+	up(&dc->sb_write_mutex);
 
 	if (dc->sb_disk)
 		folio_put(virt_to_folio(dc->sb_disk));
-- 
2.34.1


             reply	other threads:[~2026-04-02 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 13:03 mingzhe.zou [this message]
2026-04-03  4:04 ` [PATCH] bcache: fix uninitialized closure object Coly Li
  -- strict thread matches above, loose matches on Subject: below --
2026-04-03  4:21 colyli
2026-04-03 11:11 ` Jens Axboe
2026-04-07  9:28   ` Coly Li
2026-04-07 12:44     ` Jens Axboe
2026-04-07 13:19       ` Coly Li
2026-04-07 13:24         ` Jens Axboe
2026-04-07 14:09           ` Coly Li
2026-04-03 11:11 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402130353.1099802-1-mingzhe.zou@easystack.cn \
    --to=mingzhe.zou@easystack.cn \
    --cc=colyli@fnnas.com \
    --cc=colyli@kernel.org \
    --cc=linux-bcache@vger.kernel.org \
    --cc=zoumingzhe@outlook.com \
    --cc=zoumingzhe@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox