Re: [PATCH 1/2] bcache: ignore pending signals in bcache_device_init()

Coly Li
2020-04-13T08:17:32Z

On 2020/3/3 14:58, Сорокин Артем Сергеевич wrote:
> Hello Coly,
>
> On 2 Mar 2020, at 20:06, Coly Li <colyli@suse.de> wrote:
>>
>> I see your concern. But the udev timeout is global for all udev rules, I
>> am not sure whether change it to a very long time is good ... (indeed I
>> tried to add event_timeout=3600 but I can still see the signal received).
>>
>> Ignore the pending signal in bcache registering code is the only method
>> currently I know to avoid bcache auto-register failure in boot time. If
>> there is other way I can achieve the same goal, I'd like to try.
>>
>> BTW, by the mean time, I am still looking for the reason why
>> event_timeout=3600 in /etc/udev/udev.conf does not take effect...
>
> In my setup, i completely moved bcache registration from udev to systemd. As a result, there is no need to change udev timeout or worry about kill signals. But this approach breaks hot-plugging bcache devices and require to modify udev rules and probe-bcache from bcache-tools.
>
> It also helps me to manage startup dependencies to ensure that ceph-osd will start only when bcache is ready.
>
> I can elaborate on my approach if you are interested.
>

Yes please, I am interesting.

Now I continue to look at the timeout issue. I'd like to get many input
of different ideas, then make a proper way to fix.

Thanks.

Coly Li