Re: [PATCH v1 01/10] bcache: exit bch_writeback_thread() with proper task state

Michael Lyle
2018-01-05T17:09:02Z

Coly---

On Fri, Jan 5, 2018 at 9:05 AM, Coly Li <colyli@suse.de> wrote:
> It seems I need to call set_current_state(TASK_INTERRUPTIBLE) before
> up_write(&dc->writeback_lock), then dc->writeback_lock will protect and
> avoid the race. Or move set_current_state(TASK_INTERRUPTIBLE) to the
> location before the condition checks in line 469-471.

I think you're right. Sorry I missed this in my review. I will pull
this from my testing/for-416 set.

Mike