From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05207C63777 for ; Wed, 25 Nov 2020 06:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A18A0208C3 for ; Wed, 25 Nov 2020 06:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726053AbgKYGH7 (ORCPT ); Wed, 25 Nov 2020 01:07:59 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7981 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbgKYGH7 (ORCPT ); Wed, 25 Nov 2020 01:07:59 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Cgr5m3R7Vzhh8Q; Wed, 25 Nov 2020 14:07:40 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 25 Nov 2020 14:07:42 +0800 Subject: Re: [PATCH 04/45] fs: simplify freeze_bdev/thaw_bdev To: Christoph Hellwig , Jens Axboe CC: Tejun Heo , Josef Bacik , "Konrad Rzeszutek Wilk" , Coly Li , "Mike Snitzer" , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , , Richard Weinberger , Jan Kara , , , , , , References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-5-hch@lst.de> From: Chao Yu Message-ID: <4ae2d8ca-e858-e5df-67ef-d14852978976@huawei.com> Date: Wed, 25 Nov 2020 14:07:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201124132751.3747337-5-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 2020/11/24 21:27, Christoph Hellwig wrote: > Store the frozen superblock in struct block_device to avoid the awkward > interface that can return a sb only used a cookie, an ERR_PTR or NULL. > > Signed-off-by: Christoph Hellwig > --- > drivers/md/dm-core.h | 5 ----- > drivers/md/dm.c | 20 ++++++-------------- > fs/block_dev.c | 39 ++++++++++++++++----------------------- > fs/buffer.c | 2 +- > fs/ext4/ioctl.c | 2 +- > fs/f2fs/file.c | 14 +++++--------- For f2fs part, Acked-by: Chao Yu Thanks, > fs/xfs/xfs_fsops.c | 7 ++----- > include/linux/blk_types.h | 1 + > include/linux/blkdev.h | 4 ++-- > 9 files changed, 34 insertions(+), 60 deletions(-)