From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Shan Hai <shan.hai@oracle.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] bcache: release dc->writeback_lock properly in bch_writeback_thread()
Date: Wed, 22 Aug 2018 12:13:12 -0600 [thread overview]
Message-ID: <4aead749-ba4a-d5a3-d592-bff36e38d1b5@kernel.dk> (raw)
In-Reply-To: <e44eebe7-a42c-f4f9-0f2f-e7d9135f8bff@suse.de>
On 8/22/18 12:07 PM, Coly Li wrote:
> On 2018/8/23 2:02 AM, Coly Li wrote:
>> From: Shan Hai <shan.hai@oracle.com>
>>
>> The writeback thread would exit with a lock held when the cache device is
>> detached via sysfs interface, fix it by releasing the held lock before exiting
>> the while-loop.
>>
>> Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set)
>> Signed-off-by: Shan Hai <shan.hai@oracle.com>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> Tested-by: Shenghui Wang <shhuiw@foxmail.com>
>> Cc: stable@vger.kernel.org #4.17+
>> ---
>> Changelog:
>> v2: add Fixes tag by Coly Li.
>> v1: initial patch from Shan Hai.
>
> Hi Jens,
>
> Please pick this patch for your next pull request. The change from Shan
> Hai fixes a real issue which is reported and lately verified by Shenghui
> Wang.
Applied - but I fixed up the commit message. Please keep lines at
72 characters for git commits.
--
Jens Axboe
prev parent reply other threads:[~2018-08-22 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 18:02 [PATCH v2] bcache: release dc->writeback_lock properly in bch_writeback_thread() Coly Li
2018-08-22 18:07 ` Coly Li
2018-08-22 18:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aead749-ba4a-d5a3-d592-bff36e38d1b5@kernel.dk \
--to=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=shan.hai@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).