linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Pyrgiotis <apyrgio-Hpc4xzY4zrDSDkk6z29a7FAUjnlXr6A1@public.gmane.org>
To: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Journal question
Date: Mon, 24 Dec 2012 20:46:30 +0200	[thread overview]
Message-ID: <50D8A306.8050109@cslab.ece.ntua.gr> (raw)
In-Reply-To: <50D8961A.1010703-Hpc4xzY4zrDSDkk6z29a7FAUjnlXr6A1@public.gmane.org>

Hi Kent,

I was reading the code documentation on your site, and I saw that you 
have written this:

"... In the future, the journal will contain a strong checksum of the 
data so that the write will complete when the journal entry finishes..."

My question is, is this feature implemented? As far as I can see by 
looking at journal.c, you are journaling only the keys and not the data 
they point to (it has been issued asynchronously a few steps back to the 
SSD, right?).
Also, if this is a feature to be implemented, wouldn't it create more 
stress on the CPUs, as well as more latency to issue the IO request to 
the SSDs (unless you issue it asynchronously while processing the keylist)?

I'm just curious on how you'd handle it.

Thanks,
Alex

       reply	other threads:[~2012-12-24 18:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50D8961A.1010703@cslab.ece.ntua.gr>
     [not found] ` <50D8961A.1010703-Hpc4xzY4zrDSDkk6z29a7FAUjnlXr6A1@public.gmane.org>
2012-12-24 18:46   ` Alex Pyrgiotis [this message]
     [not found]     ` <50D8A306.8050109-Hpc4xzY4zrDSDkk6z29a7FAUjnlXr6A1@public.gmane.org>
2012-12-26 18:32       ` Journal question Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D8A306.8050109@cslab.ece.ntua.gr \
    --to=apyrgio-hpc4xzy4zrdsdkk6z29a7faujnlxr6a1@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).