From: Stefan Priebe - Profihost AG <s.priebe-2Lf/h1ldwEHR5kwTpVNS9A@public.gmane.org>
To: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
Cc: "linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Raw stats
Date: Fri, 12 Jul 2013 08:14:40 +0200 [thread overview]
Message-ID: <51DF9ED0.9010103@profihost.ag> (raw)
In-Reply-To: <20130712013308.GD17799@kmo-pixel>
Am 12.07.2013 03:33, schrieb Kent Overstreet:
> On Thu, Jul 11, 2013 at 07:35:01AM +0200, Stefan Priebe - Profihost AG wrote:
>> The stats_total counters are formatted to GB MB,... for several use cases raw values would be better (f.e.nagios plugin). Is this possible?
>
> Heh, I imagine Greg K-H or someone would say the sysfs stuff should only
> be exporting the raw values..
>
> It'd be pretty easy to add _raw versions, though - or maybe _bytes? I'm
> not terribly eager to wade through the sysfs code right this minute, but
> the sysfs code should be pretty easy to figure out if you want to try
> it and I'd take a patch.
>
> (Look for sysfs_hprint() calls in sysfs.c and stats.c; add attributes
> (the read_attribute() things) for the files you want to add and
> sysfs_print() calls for the raw versions)
I would vote for dropping this human stuff too and use raw / byte values
in general. Makeing nice looking values out of it is always up to utils
or the user.
Greets,
Stefan
prev parent reply other threads:[~2013-07-12 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 5:35 Raw stats Stefan Priebe - Profihost AG
[not found] ` <DE95649B-13EB-4733-BFCD-4B67F82D179B-2Lf/h1ldwEHR5kwTpVNS9A@public.gmane.org>
2013-07-12 1:33 ` Kent Overstreet
2013-07-12 6:14 ` Stefan Priebe - Profihost AG [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DF9ED0.9010103@profihost.ag \
--to=s.priebe-2lf/h1ldwehr5kwtpvns9a@public.gmane.org \
--cc=kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox