public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: "Cyril B." <cbay-SxHCd5+OuqTrt3ojHgZu+w@public.gmane.org>
To: Gabriel de Perthuis <g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>,
	linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Don't register if a non-bcache superblock is found as well
Date: Mon, 22 Jul 2013 16:36:08 +0200	[thread overview]
Message-ID: <51ED4358.6030005@excellency.fr> (raw)
In-Reply-To: <51ED10C4.2050808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Gabriel de Perthuis wrote:
>> I'm afraid that doesn't work: with that patch, my backing device doesn't even get registered anymore, since blkid will detect it as XFS:
>
> I just tried making an xfs filesystem on a bcache device,
> and the xfs superblock isn't visible to the backing device.
>
> Your problem is likely an old superblock; use wipefs before make-bcache.
>
> If you do find a filesystem that doesn't put its blkid magic
> at a fixed offset from the start of the device, we could
> consider alternatives, like whitelisting them or porting to blkid.
>
> For now, better safe than sorry.


After zeroing my devices and trying again, I cannot reproduce the issue. 
I guess you're right, I must have had an old superblock or something.

Thanks for the fix.

Cyril

      parent reply	other threads:[~2013-07-22 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 16:20 Filesystem corruption caused by disk from backing device kicked out of RAID1 array Cyril B.
2013-07-21 18:17 ` [PATCH] Don't register if a non-bcache superblock is found as well Gabriel
     [not found]   ` <1374430637-12954-1-git-send-email-g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-22  1:59     ` Kent Overstreet
2013-07-22 10:38     ` Cyril B.
     [not found]       ` <51ED0BAB.4040604-SxHCd5+OuqTrt3ojHgZu+w@public.gmane.org>
2013-07-22 11:00         ` Gabriel de Perthuis
     [not found]           ` <51ED10C4.2050808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-22 14:36             ` Cyril B. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ED4358.6030005@excellency.fr \
    --to=cbay-sxhcd5+ouqtrt3ojhgzu+w@public.gmane.org \
    --cc=g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox