From: Gabriel de Perthuis <g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: bcache-tools: minor change for bcache-register
Date: Tue, 27 Aug 2013 00:16:32 +0200 [thread overview]
Message-ID: <521BD3C0.9070209@gmail.com> (raw)
In-Reply-To: <20130826214848.GC2798@kmo-pixel>
>> I'll just send a patch to change "device already registered"
>> to a low-priority pr_debug message rather than something that
>> looks like an error.
>
> register_quiet isn't supposed to suppress legit errors - if it does
> that's a bug
It does suppress all the err = "…" messages in register_bcache from super.c;
I don't know how often they come up in practice. From the read_super call
on, errors get reported by the called functions.
next prev parent reply other threads:[~2013-08-26 22:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 9:14 bcache-tools: minor change for bcache-register Rolf Fokkens
[not found] ` <521B1C5E.2090007-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-26 16:17 ` Darrick J. Wong
2013-08-26 16:31 ` Gabriel de Perthuis
2013-08-26 16:54 ` [PATCH] bcache: Downgrade "device already registered" to pr_debug Gabriel de Perthuis
2013-08-26 21:48 ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-26 22:16 ` Gabriel de Perthuis [this message]
[not found] ` <521BD3C0.9070209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:31 ` [PATCH] bcache: register_quiet should still report errors Gabriel de Perthuis
[not found] ` <1377556306-29938-1-git-send-email-g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:37 ` Gabriel de Perthuis
2013-08-26 21:41 ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-27 6:58 ` Rolf Fokkens
[not found] ` <521C4E2B.8090008-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 10:00 ` Alex Pyrgiotis
2013-08-27 11:45 ` Gabriel de Perthuis
2013-08-27 12:02 ` Rolf Fokkens
[not found] ` <521C9560.2020603-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 12:11 ` Gabriel de Perthuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521BD3C0.9070209@gmail.com \
--to=g2p.code-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox