From: Alex Pyrgiotis <apyrgio-Sqt7GMbKoOQ@public.gmane.org>
To: Rolf Fokkens <rolf-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
Cc: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: bcache-tools: minor change for bcache-register
Date: Tue, 27 Aug 2013 13:00:24 +0300 [thread overview]
Message-ID: <521C78B8.7060402@grnet.gr> (raw)
In-Reply-To: <521C4E2B.8090008-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
On 08/27/2013 09:58 AM, Rolf Fokkens wrote:
> Would you consider another change as well:
>
> --- bcache-tools-20130827.orig/bcache-register 2013-08-26
> 23:46:19.000000000 +0200
> +++ bcache-tools-20130827/bcache-register 2013-08-27
> 08:55:48.060477014 +0200
> @@ -1,4 +1,4 @@
> #!/bin/sh
> -modprobe -qba bcache
> +/sbin/modprobe -qba bcache
> test -f /sys/fs/bcache/register_quiet && echo "$1" >
> /sys/fs/bcache/register_quiet
>
> /sbin is not in the $PATH for utilities started from udev. For Fedora it
> isn't anyway, but it won't harm other distro's neither.
>
Hi all,
Pardon the interrupt, but this is not the case for Arch Linux:
https://www.archlinux.org/news/binaries-move-to-usrbin-requiring-update-intervention/
In my opinion, if modprobe *has* to be called with the exact path name,
it would probably be clearer to use `which modprobe` and then call the
result.
Just my two cents...
--
Alex | apyrgio-Sqt7GMbKoOQ@public.gmane.org
next prev parent reply other threads:[~2013-08-27 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 9:14 bcache-tools: minor change for bcache-register Rolf Fokkens
[not found] ` <521B1C5E.2090007-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-26 16:17 ` Darrick J. Wong
2013-08-26 16:31 ` Gabriel de Perthuis
2013-08-26 16:54 ` [PATCH] bcache: Downgrade "device already registered" to pr_debug Gabriel de Perthuis
2013-08-26 21:48 ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-26 22:16 ` Gabriel de Perthuis
[not found] ` <521BD3C0.9070209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:31 ` [PATCH] bcache: register_quiet should still report errors Gabriel de Perthuis
[not found] ` <1377556306-29938-1-git-send-email-g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 22:37 ` Gabriel de Perthuis
2013-08-26 21:41 ` bcache-tools: minor change for bcache-register Kent Overstreet
2013-08-27 6:58 ` Rolf Fokkens
[not found] ` <521C4E2B.8090008-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 10:00 ` Alex Pyrgiotis [this message]
2013-08-27 11:45 ` Gabriel de Perthuis
2013-08-27 12:02 ` Rolf Fokkens
[not found] ` <521C9560.2020603-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org>
2013-08-27 12:11 ` Gabriel de Perthuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521C78B8.7060402@grnet.gr \
--to=apyrgio-sqt7gmbkooq@public.gmane.org \
--cc=kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rolf-6w2rdlBuEQTpMFipWq+H6g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox