From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel de Perthuis Subject: Re: bcache-tools package for Fedora / status probe-bcache Date: Thu, 05 Sep 2013 12:53:13 +0200 Message-ID: <52286299.7000708@gmail.com> References: <521A55D4.20908@rolffokkens.nl> <52282A87.4000801@rolffokkens.nl> <52285A03.7080802@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: util-linux-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Karel Zak Cc: Rolf Fokkens , "linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , util-linux List-Id: linux-bcache@vger.kernel.org >> I'm not a fan of a blkid csum check (I pointed it out on the >> bug[1]). If a superblock gets scribbled or corrupted, you want >> bcache to complain, and you don't want blkid to look for the next >> possible signature. > > Having blkid also verify the csum was requested by Karel Zak, the > maintainer of util-linux. As a packager of bcache-tools I'm in favour > of having blkid identify bcache, but I don't have a preference on > using csum to identify bcache. I can pass the message to Karel, but > it would be better if we both discuss it on the appropriate > (util-linux?) mail list. Karel, are you okay if blkid doesn't do the csum verification discussed above? Checksum failures will be reported by the kernel instead. Alternatively, do you see a way libblkid can return good magic / bad checksum results? >>> So now I'm wondering: are there any particular reasons to keep >>> probe-bcache part of the package, or will it really be obsolete? >> >> If you address the above and tweak the udev rules, why not. >> >> The upstream repo will need to keep probe-bcache for a while >> longer, because we don't have a way to require a sufficiently >> recent libblkid. > > I agree, f20 is a specific case, but in general probe-bcache will be > needed for a while. For the record, the libblkid patch is a good thing in the long run: common interface, less forks in udev. >> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1001120#c9 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html