From: Gabriel de Perthuis <g2p.code@gmail.com>
To: linux stable <stable@vger.kernel.org>, Greg KH <greg@kroah.com>
Cc: cbay@excellency.fr,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>
Subject: Re: bcache oops in bch_insert_data with the latest stables fixes (3.10.15)
Date: Wed, 09 Oct 2013 00:13:56 +0200 [thread overview]
Message-ID: <525483A4.5020607@gmail.com> (raw)
In-Reply-To: <525186E3.4000905@gmail.com>
Le 06/10/2013 17:50, Gabriel de Perthuis a écrit :
> Le 06/10/2013 12:38, Cyril B. a écrit :
>> Hello,
>>
>> I get the following oops immediately after booting on 3.10.15.
>> Everything works fine in 3.10.10. Both the backing and cache devices are
>> on top of mdadm.
>
> Reverting c0f04d88e46d14de51f4baebb6efafb7d59e9f96 fixes it; it was one
> of the few commits that's in 3.12 and -stable but not in
> bcache-for-3.11. That commit causes bch_insert_data to be called with
> an unset op.cache_bio.
Pinging stable,
http://git.kernel.org/linus/c0f04d88e46d14de51f4baebb6efafb7d59e9f96
should be reverted. It was in 3.11.4 and 3.10.15 (and 3.12-rc3).
It breaks bcache's writeback mode by calling bch_writeback_data without
setting cache_bio (it's more visible here[1]). There's a bit of
indirection through closure calls, but it could never work.
|1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c0f04d88e46d14de51f4baebb6efafb7d59e9f96&context=8
next prev parent reply other threads:[~2013-10-08 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 10:38 bcache oops in bch_insert_data with the latest stables fixes (3.10.15) Cyril B.
[not found] ` <52513DBD.80005-SxHCd5+OuqTrt3ojHgZu+w@public.gmane.org>
2013-10-06 15:50 ` Gabriel de Perthuis
2013-10-08 22:13 ` Gabriel de Perthuis [this message]
[not found] ` <525483A4.5020607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-08 22:32 ` Kent Overstreet
2013-10-09 21:25 ` Greg KH
2013-10-11 7:07 ` Kent Overstreet
2013-10-11 15:51 ` Greg KH
2013-10-08 22:39 ` matthew patton
[not found] ` <1381271982.70536.YahooMailNeo-XYahOdtEMNnuQS8rMknbopOW+3bF1jUfVpNB7YpNyf8@public.gmane.org>
2013-10-08 22:48 ` Gabriel de Perthuis
[not found] ` <52548BBD.9060601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-09 7:41 ` Alfredo Sola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525483A4.5020607@gmail.com \
--to=g2p.code@gmail.com \
--cc=cbay@excellency.fr \
--cc=greg@kroah.com \
--cc=linux-bcache@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox