linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Changes in /sys/bcache in kernel 3.13
@ 2014-02-18 22:28 Rolf Fokkens
  2014-02-19  2:32 ` Darrick J. Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Rolf Fokkens @ 2014-02-18 22:28 UTC (permalink / raw)
  To: linux-bcache, Darrick J. Wong

Hi All,

bcache-status stopped working in kernel 3.13, see also: 
https://bugzilla.redhat.com/show_bug.cgi?id=1066555

It's probably related to the change "Fix dirty_data accounting" in 
kernel 3.13-rc4. What specifically has changes is the fact that that 
/sys/fs/bcache/<UUID>/dirty_data has been removed, which breaks 
bcache-status (https://gist.github.com/djwong/6343451). Just removing 
the check / reference to this dirty_data item fixes bcache-status. Or 
has it been replaced by a specific item?

Oh, BTW: bcache.txt still refers to dirty_data in /sys/fs/bcache/<UUID> 
which doesn't seem correct to me.

Cheers,

Rolf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Changes in /sys/bcache in kernel 3.13
  2014-02-18 22:28 Changes in /sys/bcache in kernel 3.13 Rolf Fokkens
@ 2014-02-19  2:32 ` Darrick J. Wong
  2014-02-27 21:33   ` Rolf Fokkens
  0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2014-02-19  2:32 UTC (permalink / raw)
  To: Rolf Fokkens; +Cc: linux-bcache

On Tue, Feb 18, 2014 at 11:28:24PM +0100, Rolf Fokkens wrote:
> Hi All,
> 
> bcache-status stopped working in kernel 3.13, see also:
> https://bugzilla.redhat.com/show_bug.cgi?id=1066555

Oh, there are RH bugzillas about bcache-status problems?  I guess that makes me
'upstream'.  :D

Well, I guess I'll fix the no-newline-at-end problem too.

> It's probably related to the change "Fix dirty_data accounting" in
> kernel 3.13-rc4. What specifically has changes is the fact that that
> /sys/fs/bcache/<UUID>/dirty_data has been removed, which breaks
> bcache-status (https://gist.github.com/djwong/6343451). Just
> removing the check / reference to this dirty_data item fixes
> bcache-status. Or has it been replaced by a specific item?

<shrug> I simply removed the dirty_data line and prettied up some of the
formatting too.  I don't have a problem with pulling the dirty data stats off
the backing device.

Gist updated.

--D
> 
> Oh, BTW: bcache.txt still refers to dirty_data in
> /sys/fs/bcache/<UUID> which doesn't seem correct to me.
> 
> Cheers,
> 
> Rolf
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Changes in /sys/bcache in kernel 3.13
  2014-02-19  2:32 ` Darrick J. Wong
@ 2014-02-27 21:33   ` Rolf Fokkens
  0 siblings, 0 replies; 3+ messages in thread
From: Rolf Fokkens @ 2014-02-27 21:33 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: linux-bcache

On 02/19/2014 03:32 AM, Darrick J. Wong wrote:
> Oh, there are RH bugzillas about bcache-status problems? I guess that 
> makes me 'upstream'. :D Well, I guess I'll fix the no-newline-at-end 
> problem too.
Thanks for accepting the upstream responsibility :-)
> <shrug> I simply removed the dirty_data line and prettied up some of 
> the formatting too. I don't have a problem with pulling the dirty data 
> stats off the backing device. Gist updated. --D 
Thanks. I updated the Fedora package.

Rolf

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-27 21:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 22:28 Changes in /sys/bcache in kernel 3.13 Rolf Fokkens
2014-02-19  2:32 ` Darrick J. Wong
2014-02-27 21:33   ` Rolf Fokkens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).