public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: Francis Moreau <francis.moro@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Peter Kieser <peter@kieser.ca>,
	kmo@daterainc.com, linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: fix uninterruptible sleep in writeback thread
Date: Mon, 02 Jun 2014 16:07:53 +0200	[thread overview]
Message-ID: <538C8539.1060607@gmail.com> (raw)
In-Reply-To: <5374F9D2.8020209@kernel.dk>

Hello,

On 05/15/2014 07:30 PM, Jens Axboe wrote:
> On 05/15/2014 02:02 AM, Francis Moreau wrote:
>> Hello Jens,
>>
>> On 05/12/2014 08:27 PM, Peter Kieser wrote:
>>>
>>> On 2014-05-05 3:30 PM, Nikolay Amiantov wrote:
>>>> 2014-05-02 1:52 GMT+04:00 Slava Pestov <sp@datera.io>:
>>>>> There were two issues here:
>>>>>
>>>>> - writeback thread did not start until the device first became dirty
>>>>> - writeback thread used uninterruptible sleep once running
>>>>>
>>>>> Without this patch I see kernel warnings printed and a load average of
>>>>> 1.52 after booting my test VM. With this patch the warnings are gone and
>>>>> the load average is near 0.00 as expected.
>>>> I've tried this patch and it has indeed fixed [1]! Thanks!
>>>>
>>>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=69471
>>>
>>> Kent,
>>>
>>> Could you please review this patch, and have it pushed upstream?
>>>
>>
>> Would it be possible to merge this patch directly before 3.15 is being
>> released since kent don't seem to care about bugs in bcache or maybe he
>> does but very selectively ?
>>
>> Also it would be great that stable trees will be fixed.
>>
>> Eventually I would suggest to mark bcache as an experimental thing since
>> it's really not ready for production, just take a look at the bcache
>> mailing list to see why. At least people won't be disappointed when
>> they'll use bcache and see ton of koops.
> 
> I'd really like to get Kent to weigh in on this. Sometimes it appears
> straightforward to switch from uninterruptible to interruptible sleep,
> but then signals get in the way.
> 

Any progress ?

Thanks.

  reply	other threads:[~2014-06-02 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 21:52 [PATCH] bcache: fix uninterruptible sleep in writeback thread Slava Pestov
2014-05-02  7:20 ` Daniel Smedegaard Buus
2014-05-02  8:10   ` Daniel Smedegaard Buus
2014-05-05 22:30 ` Nikolay Amiantov
2014-05-12 18:27   ` Peter Kieser
2014-05-15  8:02     ` Francis Moreau
2014-05-15 16:18       ` Peter Kieser
2014-05-15 17:29         ` Ross Anderson
2014-05-15 17:30       ` Jens Axboe
2014-06-02 14:07         ` Francis Moreau [this message]
2014-07-25  7:30           ` Francis Moreau
2014-09-05  7:08             ` Francis Moreau
2014-05-17  5:47 ` Pavel Goran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538C8539.1060607@gmail.com \
    --to=francis.moro@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=kmo@daterainc.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=peter@kieser.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox