From: "Jorg Bornschein" <jb@capsec.org>
To: Eric Wheeler <bcache@lists.ewheeler.net>, Coly Li <i@coly.li>
Cc: linux-bcache@vger.kernel.org
Subject: Re: Can't register existing backing devices anymore
Date: Thu, 24 Aug 2017 21:02:07 +0000 [thread overview]
Message-ID: <57184e735953122aedea2ba28d38942c@313bd276ddca> (raw)
In-Reply-To: <alpine.LRH.2.11.1708242036250.13126@mail.ewheeler.net>
August 24, 2017 9:37 PM, "Eric Wheeler" <bcache@lists.ewheeler.net> wrote:
>> A fast fix can be:
>> @@ -404,7 +404,8 @@ long bch_bucket_alloc(struct cache *ca, unsigned
>> reserve, bool wait)
>>
>> finish_wait(&ca->set->bucket_wait, &w);
>> out:
>> - wake_up_process(ca->alloc_thread);
>> + if (ca->alloc_thread)
>> + wake_up_process(ca->alloc_thread);
>>
>> trace_bcache_alloc(ca, reserve);
>>
>> But for a proper fix, we should not open user space access interface
>> before necessary resources are ready.
>
> Great catch!
>
> Jorg, does this fix it?
Hi!
I hopefully find some time over the weekend and try it -- it's a bit painful because the machine is
headless and I have to move a monitor around to see the results...
j
next prev parent reply other threads:[~2017-08-24 21:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 12:22 Can't register existing backing devices anymore Jorg Bornschein
2017-08-13 15:23 ` Coly Li
2017-08-13 15:40 ` Jorg Bornschein
2017-08-13 15:40 ` Coly Li
2017-08-13 17:20 ` Jorg Bornschein
2017-08-14 17:17 ` Jorg Bornschein
2017-08-24 0:44 ` Eric Wheeler
2017-08-24 16:44 ` Coly Li
2017-08-24 20:36 ` Eric Wheeler
2017-08-24 21:02 ` Jorg Bornschein [this message]
2017-10-27 19:38 ` Eric Wheeler
2017-10-27 19:41 ` Michael Lyle
2017-10-27 21:14 ` Eric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57184e735953122aedea2ba28d38942c@313bd276ddca \
--to=jb@capsec.org \
--cc=bcache@lists.ewheeler.net \
--cc=i@coly.li \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox