linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: wangyijing <wangyijing@huawei.com>
To: Coly Li <i@coly.li>, Kent Overstreet <kent.overstreet@gmail.com>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [PATCH 3/3] bcache: Remove redundant block_size assignment
Date: Wed, 11 May 2016 09:12:22 +0800	[thread overview]
Message-ID: <573286F6.6070705@huawei.com> (raw)
In-Reply-To: <4a8a2115-c122-321b-e02d-ce21a15c1b5e@coly.li>



在 2016/5/10 22:51, Coly Li 写道:
> 在 16/5/10 下午4:38, Yijing Wang 写道:
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  drivers/md/bcache/super.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index 1ccb9be..64d0be6 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -134,7 +134,6 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
>>  	case BCACHE_SB_VERSION_CDEV:
>>  	case BCACHE_SB_VERSION_CDEV_WITH_UUID:
>>  		sb->nbuckets	= le64_to_cpu(s->nbuckets);
>> -		sb->block_size	= le16_to_cpu(s->block_size);
>>  		sb->bucket_size	= le16_to_cpu(s->bucket_size);
>>  
>>  		sb->nr_in_set	= le16_to_cpu(s->nr_in_set);
>>
> 
> Yes, this assignment is redundant. Could you please to add some comments
> to describe this patch before your Signed-off-by ? This will be
> informative and helpful for others who may back port the patches.

OK.

Thanks!
Yijing.

> 
> Thanks.
> 

  reply	other threads:[~2016-05-11  1:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  8:38 [PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() Yijing Wang
2016-05-10  8:38 ` [PATCH 2/3] bcache: update document info Yijing Wang
2016-05-10  8:38 ` [PATCH 3/3] bcache: Remove redundant block_size assignment Yijing Wang
2016-05-10 14:51   ` Coly Li
2016-05-11  1:12     ` wangyijing [this message]
2016-05-11  1:41   ` Eric Wheeler
2016-05-11  1:48     ` wangyijing
2016-05-11 19:16       ` Eric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573286F6.6070705@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=i@coly.li \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).