From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] bcache: bch_writeback_thread() is not freezable Date: Tue, 24 May 2016 08:18:45 -0600 Message-ID: <574462C5.40307@kernel.dk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ig0-f177.google.com ([209.85.213.177]:35818 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbcEXOSs (ORCPT ); Tue, 24 May 2016 10:18:48 -0400 Received: by mail-ig0-f177.google.com with SMTP id bi2so53120854igb.0 for ; Tue, 24 May 2016 07:18:47 -0700 (PDT) In-Reply-To: Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Jiri Kosina , Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Wheeler On 05/23/2016 05:05 PM, Jiri Kosina wrote: > On Wed, 18 May 2016, Jiri Kosina wrote: > >>>> bch_writeback_thread() is calling try_to_freeze(), but that's just an >>>> expensive no-op given the fact that the thread is not marked freezable. >>>> >>>> I/O helper kthreads, exactly such as the bcache writeback thread, actually >>>> shouldn't be freezable, because they are potentially necessary for >>>> finalizing the image write-out. >>>> >>>> Signed-off-by: Jiri Kosina >>> >>> Let's send a friendly ping on these three patches after two weeks... >> >> After a month, I think, it's time for another ping. > > [ adding Jens to CC ] > > Ok, I call it officially ridiculous now. I guess I'll be resending through > akpm. You can just send it to me, I've funneled bcache stable fixes before. > Is it a time to claim (by MAINTAINERS entry) the in-tree bcache orphaned? I think so. -- Jens Axboe