From: Jens Axboe <axboe@kernel.dk>
To: Jiri Kosina <jikos@kernel.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Eric Wheeler <bcache@lists.ewheeler.net>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable
Date: Tue, 24 May 2016 09:01:09 -0600 [thread overview]
Message-ID: <57446CB5.6080203@kernel.dk> (raw)
In-Reply-To: <alpine.LNX.2.00.1605241634270.31937@cbobk.fhfr.pm>
On 05/24/2016 08:38 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> bch_writeback_thread() is calling try_to_freeze(), but that's just an
> expensive no-op given the fact that the thread is not marked freezable.
>
> I/O helper kthreads, exactly such as the bcache writeback thread, actually
> shouldn't be freezable, because they are potentially necessary for
> finalizing the image write-out.
Applied 1-4, thanks Jiri.
--
Jens Axboe
prev parent reply other threads:[~2016-05-24 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:38 [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jiri Kosina
2016-05-24 14:38 ` [PATCH 2/4] bcache: bch_allocator_thread() " Jiri Kosina
2016-05-24 14:38 ` [PATCH 3/4] bcache: bch_gc_thread() " Jiri Kosina
2016-05-24 14:38 ` [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina
2016-05-24 14:43 ` Joe Perches
2016-05-25 5:07 ` Jiri Kosina
2016-05-25 17:35 ` Jens Axboe
2016-05-24 15:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57446CB5.6080203@kernel.dk \
--to=axboe@kernel.dk \
--cc=bcache@lists.ewheeler.net \
--cc=jikos@kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).