From: wangyijing <wangyijing@huawei.com>
To: Coly Li <i@coly.li>, axboe@fb.com, kent.overstreet@gmail.com
Cc: git@linux.ewheeler.net, colyli@suse.de,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bcache: Remove redundant set_capacity
Date: Mon, 28 Nov 2016 08:51:41 +0800 [thread overview]
Message-ID: <583B7F9D.3050208@huawei.com> (raw)
In-Reply-To: <749db728-10d0-ab33-4587-9b6b0e98725e@coly.li>
在 2016/11/27 15:57, Coly Li 写道:
> On 2016/11/25 上午9:39, Yijing Wang wrote:
>> set_capacity() has been called in bcache_device_init(),
>> remove the redundant one.
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> drivers/md/bcache/super.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index 849ad44..b638a16 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1126,9 +1126,6 @@ static int cached_dev_init(struct cached_dev *dc, unsigned block_size)
>> if (ret)
>> return ret;
>>
>> - set_capacity(dc->disk.disk,
>> - dc->bdev->bd_part->nr_sects - dc->sb.data_offset);
>> -
>> dc->disk.disk->queue->backing_dev_info.ra_pages =
>> max(dc->disk.disk->queue->backing_dev_info.ra_pages,
>> q->backing_dev_info.ra_pages);
>>
>
> Hi Yijing,
>
> Nice catch, it looks good to me.
>
> Acked-by: Coly Li <colyli@suse.de>
Thanks!
>
next prev parent reply other threads:[~2016-11-28 0:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 1:39 [PATCH 1/2] bcache: Remove redundant set_capacity Yijing Wang
2016-11-27 7:57 ` Coly Li
2016-11-28 0:51 ` wangyijing [this message]
2016-11-29 20:49 ` Eric Wheeler
2016-11-30 2:00 ` wangyijing
2016-11-30 18:34 ` Eric Wheeler
2016-12-01 9:24 ` wangyijing
2016-12-01 22:02 ` Eric Wheeler
2016-12-02 0:54 ` wangyijing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583B7F9D.3050208@huawei.com \
--to=wangyijing@huawei.com \
--cc=axboe@fb.com \
--cc=colyli@suse.de \
--cc=git@linux.ewheeler.net \
--cc=i@coly.li \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).