From: wangyijing <wangyijing@huawei.com>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: axboe@fb.com, kent.overstreet@gmail.com, git@linux.ewheeler.net,
colyli@suse.de, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bcache: Remove redundant set_capacity
Date: Fri, 2 Dec 2016 08:54:25 +0800 [thread overview]
Message-ID: <5840C641.30904@huawei.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1612011359150.22682@mail.ewheeler.net>
>>> I want to make sure that the set_capacity call that happens on cache
>>> attachment is not necessary when a backing device is attached without
>>
>> Hi Eric, set_capacity() which removed in this patch is happened at cached_dev_init()
>> which is called when register a backing device, what do you mean "set_capacity call that happens on cache
>>> attachment" ?
>
>
> I'm sorry, you are correct. I though this was the cache-dev attachment,
> not the cached-dev attachment. Looks good.
>
> Reviewed-by: Eric Wheeler <bcache@linux.ewheeler.net>
>
Thanks！
> --
> Eric Wheeler
>
>>
>>
>>> its dirty writeback cache since bcache0 is not presented until the cache
>>> attaches in that case.
>>
>> I found bcache0 device present once we do make-bcache -B /dev/nvme1n1. before attach the cache set.
>> So I missed something ?
>>
>>>
>>> Can you also unregister the volume, attach the backing device first, and
>>> then the cache while the cache is dirty to make sure that the size is set
>>> correctly?
>>
>> When I unregister the cache device, I found all the dirty data has been flushed to
>> backing device, so how can I do the test the case as you point ?
>>
>> Thanks!
>> Yijing.
>>
>>>
>>> --
>>> Eric Wheeler
>>>
>>>>
>>>>>
>>>>> -Eric
>>>>>
>>>>>> dc->disk.disk->queue->backing_dev_info.ra_pages =
>>>>>> max(dc->disk.disk->queue->backing_dev_info.ra_pages,
>>>>>> q->backing_dev_info.ra_pages);
>>>>>> --
>>>>>> 2.5.0
>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
>>>>>> the body of a message to majordomo@vger.kernel.org
>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>>
>>>>> .
>>>>>
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
> .
>
prev parent reply other threads:[~2016-12-02 0:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 1:39 [PATCH 1/2] bcache: Remove redundant set_capacity Yijing Wang
2016-11-27 7:57 ` Coly Li
2016-11-28 0:51 ` wangyijing
2016-11-29 20:49 ` Eric Wheeler
2016-11-30 2:00 ` wangyijing
2016-11-30 18:34 ` Eric Wheeler
2016-12-01 9:24 ` wangyijing
2016-12-01 22:02 ` Eric Wheeler
2016-12-02 0:54 ` wangyijing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5840C641.30904@huawei.com \
--to=wangyijing@huawei.com \
--cc=axboe@fb.com \
--cc=bcache@lists.ewheeler.net \
--cc=colyli@suse.de \
--cc=git@linux.ewheeler.net \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).