From: Coly Li <colyli@suse.de>
To: Michael Lyle <mlyle@lyle.org>
Cc: Pavel Goran <via-bcache@pvgoran.name>, Nix <nix@esperi.org.uk>,
linux-bcache <linux-bcache@vger.kernel.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH v3 00/13] bcache: device failure handling improvement
Date: Fri, 26 Jan 2018 14:23:27 +0800 [thread overview]
Message-ID: <68489606-77f7-973e-f6fe-c0847330ca68@suse.de> (raw)
In-Reply-To: <CAJ+L6qdLHXzOyKsacCdwB3QKKdnWdxo3kna-Zff8Bv2EfnmR8g@mail.gmail.com>
On 26/01/2018 1:51 PM, Michael Lyle wrote:
> Hey Coly,
>
> On Thu, Jan 25, 2018 at 8:56 PM, Coly Li <colyli@suse.de> wrote:
>> In order to make the failure handling simple and fast, I will not
>> distinct each bcache device whether it has dirty data on cache set. Once
>> the cache set is dirty, all attached bcache devices will be stopped.
>
> Surely it shouldn't stop any writethrough/writearound ones though, right?
>
>> It seems when this option is enabled by users, it should work for
>> writeback and writethrough, and no side effect to writearound and non.
>
> Writethrough should be the same as writearound, shouldn't it?
Yes, they are no different with such an option.
Coly Li
next prev parent reply other threads:[~2018-01-26 6:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 14:42 [PATCH v3 00/13] bcache: device failure handling improvement Coly Li
2018-01-14 14:42 ` [PATCH v3 01/13] bcache: set writeback_rate_update_seconds in range [1, 60] seconds Coly Li
2018-01-16 9:03 ` Hannes Reinecke
2018-01-14 14:42 ` [PATCH v3 02/13] bcache: properly set task state in bch_writeback_thread() Coly Li
2018-01-16 9:02 ` Hannes Reinecke
2018-01-14 14:42 ` [PATCH v3 03/13] bcache: set task properly in allocator_wait() Coly Li
2018-01-16 9:05 ` Hannes Reinecke
2018-01-16 9:29 ` Coly Li
2018-01-14 14:42 ` [PATCH v3 04/13] bcache: fix cached_dev->count usage for bch_cache_set_error() Coly Li
2018-01-14 14:42 ` [PATCH v3 05/13] bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set Coly Li
2018-01-16 9:11 ` Hannes Reinecke
2018-01-26 6:21 ` Coly Li
2018-01-14 14:42 ` [PATCH v3 06/13] bcache: stop dc->writeback_rate_update properly Coly Li
2018-01-14 14:42 ` [PATCH v3 07/13] bcache: set error_limit correctly Coly Li
2018-01-14 14:42 ` [PATCH v3 08/13] bcache: add CACHE_SET_IO_DISABLE to struct cache_set flags Coly Li
2018-01-14 14:42 ` [PATCH v3 09/13] bcache: stop all attached bcache devices for a retired cache set Coly Li
2018-01-14 14:42 ` [PATCH v3 10/13] bcache: fix inaccurate io state for detached bcache devices Coly Li
2018-01-16 9:27 ` Hannes Reinecke
2018-01-14 14:42 ` [PATCH v3 11/13] bcache: add backing_request_endio() for bi_end_io of attached backing device I/O Coly Li
2018-01-16 9:28 ` Hannes Reinecke
2018-01-14 14:42 ` [PATCH v3 12/13] bcache: add io_disable to struct cached_dev Coly Li
2018-01-16 9:32 ` Hannes Reinecke
2018-01-14 14:42 ` [PATCH v3 13/13] bcache: stop bcache device when backing device is offline Coly Li
2018-01-16 9:33 ` Hannes Reinecke
2018-01-24 22:23 ` [PATCH v3 00/13] bcache: device failure handling improvement Nix
2018-01-25 3:35 ` Re[2]: " Pavel Goran
2018-01-25 18:57 ` Nix
2018-01-26 4:15 ` Re[2]: " Pavel Goran
2018-01-26 4:56 ` Coly Li
2018-01-26 5:51 ` Michael Lyle
2018-01-26 6:23 ` Coly Li [this message]
2018-02-16 12:11 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68489606-77f7-973e-f6fe-c0847330ca68@suse.de \
--to=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=nix@esperi.org.uk \
--cc=via-bcache@pvgoran.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).