From: Michael Lyle <mlyle@lyle.org>
To: Hannes Reinecke <hare@suse.de>, Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] bcache: set task state correctly in allocator_wait()
Date: Wed, 22 Nov 2017 09:57:40 -0800 [thread overview]
Message-ID: <6ae16d24-d7da-ba48-ddc8-7d715930eb2b@lyle.org> (raw)
In-Reply-To: <0c8e78ab-e369-a40c-ee02-6a6c8f3a5cdd@suse.de>
Hey everyone--
On 11/22/2017 06:10 AM, Hannes Reinecke wrote:
> _Actually_ there is a push to remove all kthreads in the kernel, as they
> don't play nice together with RT.
> So while you're at it, do you think it'd be possible to convert it to a
> workqueue? Sebastian will be happy to help you here, right, Sebastian?
I don't see a reason why moving this away from a thread would be
advantageous. There's neither devastating complexity in the current
form nor a need for additional concurrency (at least right now).
As it turns out, we're broken for RT for other reasons, but that has to
do with our use of closures and releasing locks in different threads
from where they're allocated. The natural answer is completions, but
that's not easily done with the current structure of the code.
This current code is neither a problem for RT nor for
performance/legibility on mainline.
Mike
prev parent reply other threads:[~2017-11-22 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 12:33 [PATCH] bcache: set task state correctly in allocator_wait() Coly Li
2017-11-22 14:10 ` Hannes Reinecke
2017-11-22 14:55 ` Sebastian Andrzej Siewior
2017-11-22 16:44 ` Coly Li
2017-11-22 17:57 ` Michael Lyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae16d24-d7da-ba48-ddc8-7d715930eb2b@lyle.org \
--to=mlyle@lyle.org \
--cc=bigeasy@linutronix.de \
--cc=colyli@suse.de \
--cc=hare@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox