From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD879C77B73 for ; Tue, 6 Jun 2023 08:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbjFFIUx convert rfc822-to-8bit (ORCPT ); Tue, 6 Jun 2023 04:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbjFFIUv (ORCPT ); Tue, 6 Jun 2023 04:20:51 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9299DFA; Tue, 6 Jun 2023 01:20:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 89E7C63CC135; Tue, 6 Jun 2023 10:20:47 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id w2bdPD93IvhE; Tue, 6 Jun 2023 10:20:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 14A1D616B2CD; Tue, 6 Jun 2023 10:20:47 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id X5LSD106M-YC; Tue, 6 Jun 2023 10:20:46 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id D62D563CC135; Tue, 6 Jun 2023 10:20:46 +0200 (CEST) Date: Tue, 6 Jun 2023 10:20:46 +0200 (CEST) From: Richard Weinberger To: hch Cc: Jens Axboe , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Al Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel , linux-block , linux-um , linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd , linux-nvme@lists.infradead.org, linux-btrfs , linux-f2fs-devel , linux-nilfs@vger.kernel.org, linux-fsdevel , linux-pm Message-ID: <766259639.3687124.1686039646763.JavaMail.zimbra@nod.at> In-Reply-To: <20230606073950.225178-26-hch@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-26-hch@lst.de> Subject: Re: [PATCH 25/31] ubd: remove commented out code in ubd_open MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: remove commented out code in ubd_open Thread-Index: XkjrL/wptcQ24bQlPJHDQOJLYTpcmQ== Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "hch" > This code has been dead forever, make sure it doesn't show up in code > searches. > > Signed-off-by: Christoph Hellwig > --- > arch/um/drivers/ubd_kern.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > index 8b79554968addb..20c1a16199c503 100644 > --- a/arch/um/drivers/ubd_kern.c > +++ b/arch/um/drivers/ubd_kern.c > @@ -1170,13 +1170,6 @@ static int ubd_open(struct gendisk *disk, fmode_t mode) > } > ubd_dev->count++; > set_disk_ro(disk, !ubd_dev->openflags.w); > - > - /* This should no more be needed. And it didn't work anyway to exclude > - * read-write remounting of filesystems.*/ > - /*if((mode & FMODE_WRITE) && !ubd_dev->openflags.w){ > - if(--ubd_dev->count == 0) ubd_close_dev(ubd_dev); > - err = -EROFS; > - }*/ Acked-by: Richard Weinberger Thanks, //richard