From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH V15 14/18] block: enable multipage bvecs Date: Thu, 28 Feb 2019 12:39:10 +0000 Message-ID: <83c1e25b-4aab-4374-e160-b506eea9e68f@nvidia.com> References: <20190215111324.30129-1-ming.lei@redhat.com> <20190215111324.30129-15-ming.lei@redhat.com> <6c9ae4de-c56f-a2b3-2542-da7d8b95601d@samsung.com> <0dbbee64-5c6b-0374-4360-6dc218c70d58@nvidia.com> <20190227232940.GA13319@ming.t460p> <01155e88-f021-fbe2-d048-42e303fe2935@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <01155e88-f021-fbe2-d048-42e303fe2935@samsung.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski , Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh List-Id: linux-bcache@vger.kernel.org On 28/02/2019 07:51, Marek Szyprowski wrote: > Hi Ming, > > On 2019-02-28 00:29, Ming Lei wrote: >> On Wed, Feb 27, 2019 at 08:47:09PM +0000, Jon Hunter wrote: >>> On 21/02/2019 08:42, Marek Szyprowski wrote: >>>> On 2019-02-15 12:13, Ming Lei wrote: >>>>> This patch pulls the trigger for multi-page bvecs. >>>>> >>>>> Reviewed-by: Omar Sandoval >>>>> Signed-off-by: Ming Lei >>>> Since Linux next-20190218 I've observed problems with block layer on one >>>> of my test devices (Odroid U3 with EXT4 rootfs on SD card). Bisecting >>>> this issue led me to this change. This is also the first linux-next >>>> release with this change merged. The issue is fully reproducible and can >>>> be observed in the following kernel log: >>>> >>>> sdhci: Secure Digital Host Controller Interface driver >>>> sdhci: Copyright(c) Pierre Ossman >>>> s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 (100000000 Hz) >>>> s3c-sdhci 12530000.sdhci: Got CD GPIO >>>> mmc0: SDHCI controller on samsung-hsmmc [12530000.sdhci] using ADMA >>>> mmc0: new high speed SDHC card at address aaaa >>>> mmcblk0: mmc0:aaaa SL16G 14.8 GiB >>> I have also noticed some failures when writing to an eMMC device on one >>> of our Tegra boards. We have a simple eMMC write/read test and it is >>> currently failing because the data written does not match the source. >>> >>> I did not seem the same crash as reported here, however, in our case the >>> rootfs is NFS mounted and so probably would not. However, the bisect >>> points to this commit and reverting on top of -next fixes the issues. >> It is sdhci, probably related with max segment size, could you test the >> following patch: >> >> https://marc.info/?l=linux-mmc&m=155128334122951&w=2 > > This seems to be fixing my issue too! Thanks! Thanks, I can confirm this fixes the issue for Tegra. So feel free to add my ... Tested-by: Jon Hunter Cheers! Jon -- nvpublic