From: Coly Li <colyli@suse.de>
To: Nix <nix@esperi.org.uk>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
Michael Lyle <mlyle@lyle.org>,
Junhui Tang <tang.junhui@zte.com.cn>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v4 13/13] bcache: add stop_when_cache_set_failed to struct cached_dev
Date: Mon, 29 Jan 2018 21:02:18 +0800 [thread overview]
Message-ID: <9f2e507d-bc5b-333b-eefe-d76a6440fdcf@suse.de> (raw)
In-Reply-To: <87inbkesbg.fsf@esperi.org.uk>
On 29/01/2018 8:57 PM, Nix wrote:
> On 27 Jan 2018, Coly Li said:
>
>> Current bcache failure handling code will stop all attached bcache devices
>> when the cache set is broken or disconnected. This is desired behavior for
>> most of enterprise or cloud use cases, but maybe not for low end
>> configuration. Nix <nix@esperi.org.uk> points out, users may still want to
>> access the bcache device after cache device failed, for example on laptops.
>
> Actually I'm much interested in the server use case. On laptops, it's
> relatively easy to recover if you know what you're doing, because they
> usually have a user in front of them with console access -- but if a
> remote headless server with a hundred users a thousand miles away has
> its cache device wear out I would really rather the hundred users get
> served, if more slowly, rather than the whole machine going down for
> hours or days until I can get someone there to bash on the hardware!
>
Hi Nix,
Thanks for the input, I didn't think of such use case before. It makes a
lot sense !
> (Sure, ideally you'd detect the wearing out in advance, but SSDs are not
> always nice and helpful like that and sometimes just go instantly
> readonly or simply vanish off the bus entirely without warning.)
>
Yes. Then in the v5 patch set, I will add an option for "always"/"auto",
which will leave bcache device alive if the broken cache set is clean.
Thank you all again, for the insight and brilliant suggestion !
Coly Li
next prev parent reply other threads:[~2018-01-29 13:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 14:23 [PATCH v4 00/13] bcache: device failure handling improvement Coly Li
2018-01-27 14:23 ` [PATCH v4 01/13] bcache: set writeback_rate_update_seconds in range [1, 60] seconds Coly Li
2018-02-01 21:44 ` Michael Lyle
2018-01-27 14:23 ` [PATCH v4 02/13] bcache: properly set task state in bch_writeback_thread() Coly Li
2018-02-01 21:45 ` Michael Lyle
2018-01-27 14:23 ` [PATCH v4 03/13] bcache: fix cached_dev->count usage for bch_cache_set_error() Coly Li
2018-01-27 14:23 ` [PATCH v4 04/13] bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set Coly Li
2018-01-27 14:23 ` [PATCH v4 05/13] bcache: stop dc->writeback_rate_update properly Coly Li
2018-01-27 14:23 ` [PATCH v4 06/13] bcache: set error_limit correctly Coly Li
2018-02-01 21:49 ` Michael Lyle
2018-01-27 14:24 ` [PATCH v4 07/13] bcache: add CACHE_SET_IO_DISABLE to struct cache_set flags Coly Li
2018-01-27 14:24 ` [PATCH v4 08/13] bcache: stop all attached bcache devices for a retired cache set Coly Li
2018-01-27 14:24 ` [PATCH v4 09/13] bcache: fix inaccurate io state for detached bcache devices Coly Li
2018-01-27 14:24 ` [PATCH v4 10/13] bcache: add backing_request_endio() for bi_end_io of attached backing device I/O Coly Li
2018-01-27 14:24 ` [PATCH v4 11/13] bcache: add io_disable to struct cached_dev Coly Li
2018-01-27 14:24 ` [PATCH v4 12/13] bcache: stop bcache device when backing device is offline Coly Li
2018-01-27 14:24 ` [PATCH v4 13/13] bcache: add stop_when_cache_set_failed to struct cached_dev Coly Li
2018-01-28 3:33 ` Pavel Goran
2018-01-28 4:32 ` Coly Li
2018-01-28 5:55 ` Re[2]: " Pavel Goran
2018-01-28 9:39 ` Coly Li
2018-01-29 12:57 ` Nix
2018-01-29 13:02 ` Coly Li [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-28 1:56 [PATCH v4 00/13] bcache: device failure handling improvement Coly Li
2018-01-28 1:56 ` [PATCH v4 13/13] bcache: add stop_when_cache_set_failed to struct cached_dev Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f2e507d-bc5b-333b-eefe-d76a6440fdcf@suse.de \
--to=colyli@suse.de \
--cc=hare@suse.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=nix@esperi.org.uk \
--cc=tang.junhui@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).