From: Song Liu <songliubraving@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
Coly Li <colyli@suse.de>, "axboe@kernel.dk" <axboe@kernel.dk>,
Kernel Team <Kernel-team@fb.com>,
"song@kernel.org" <song@kernel.org>
Subject: Re: [PATCH v2 1/3] block: introduce part_[begin|end]_io_acct
Date: Mon, 31 Aug 2020 21:58:33 +0000 [thread overview]
Message-ID: <B87768CF-7E00-4553-8458-D18F853D558C@fb.com> (raw)
In-Reply-To: <20200831065349.GA2507@infradead.org>
> On Aug 30, 2020, at 11:53 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Aug 18, 2020 at 03:26:43PM -0700, Song Liu wrote:
>> These functions can be used to enable iostat for partitions on devices
>> like md, bcache.
>>
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>
> EXPORT_SYMBOL_GPL for new block layer functionality, please.
>
> Otherwise this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks Christoph! Will fix and resend v3.
next prev parent reply other threads:[~2020-08-31 21:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 22:26 [PATCH v2 0/3] block: improve iostat for md/bcache partitions Song Liu
2020-08-18 22:26 ` [PATCH v2 1/3] block: introduce part_[begin|end]_io_acct Song Liu
2020-08-31 6:53 ` Christoph Hellwig
2020-08-31 21:58 ` Song Liu [this message]
2020-08-18 22:26 ` [PATCH v2 2/3] md: use part_[begin|end]_io_acct instead of disk_[begin|end]_io_acct Song Liu
2020-08-31 6:54 ` Christoph Hellwig
2020-08-18 22:26 ` [PATCH v2 3/3] bcache: " Song Liu
2020-08-31 6:54 ` Christoph Hellwig
2020-08-28 18:00 ` [PATCH v2 0/3] block: improve iostat for md/bcache partitions Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B87768CF-7E00-4553-8458-D18F853D558C@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=hch@infradead.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox