From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Coly Li <colyli@suse.de>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: use default_groups in kobj_type
Date: Sat, 8 Jan 2022 09:31:29 +0100 [thread overview]
Message-ID: <YdlL4YAScYp9XxkI@kroah.com> (raw)
In-Reply-To: <7cbca83d-bcac-464e-d2e4-c54b2d53eead@suse.de>
On Sat, Jan 08, 2022 at 02:16:28PM +0800, Coly Li wrote:
> On 1/6/22 6:00 PM, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the bcache sysfs code to use default_groups field which has
> > been the preferred way since aa30f47cf666 ("kobject: Add support for
> > default attribute groups to kobj_type") so that we can soon get rid of
> > the obsolete default_attrs field.
> >
> > Cc: Coly Li <colyli@suse.de>
> > Cc: Kent Overstreet <kent.overstreet@gmail.com>
> > Cc: linux-bcache@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> It looks good to me.
>
> Acked-by: Coly Li <colyli@suse.de>
>
> I assume you may take this patch directly in your maintenance path, but if
> you want me to take this, just let me know. Thanks.
I can take it myself, or you can, which ever is easiest for you, just
let me know which you prefer. Thanks for the review!
greg k-h
next prev parent reply other threads:[~2022-01-08 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 10:00 [PATCH] bcache: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-08 6:16 ` Coly Li
2022-01-08 8:31 ` Greg Kroah-Hartman [this message]
2022-01-10 15:53 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdlL4YAScYp9XxkI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).