From: Michael Lyle <mlyle@lyle.org>
To: Coly Li <colyli@suse.de>, linux-bcache@vger.kernel.org
Cc: linux-block@vger.kernel.org, Junhui Tang <tang.junhui@zte.com.cn>
Subject: Re: [PATCH v4 06/13] bcache: set error_limit correctly
Date: Thu, 1 Feb 2018 13:49:09 -0800 [thread overview]
Message-ID: <a809420e-c55c-d722-682a-9c8c38da45ee@lyle.org> (raw)
In-Reply-To: <20180127142406.89741-7-colyli@suse.de>
On 01/27/2018 06:23 AM, Coly Li wrote:
> Struct cache uses io_errors for two purposes,
> - Error decay: when cache set error_decay is set, io_errors is used to
> generate a small piece of delay when I/O error happens.
> - I/O errors counter: in order to generate big enough value for error
> decay, I/O errors counter value is stored by left shifting 20 bits (a.k.a
> IO_ERROR_SHIFT).
This LGTM
Reviewed-by: Michael Lyle <mlyle@lyle.org>
next prev parent reply other threads:[~2018-02-01 21:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 14:23 [PATCH v4 00/13] bcache: device failure handling improvement Coly Li
2018-01-27 14:23 ` [PATCH v4 01/13] bcache: set writeback_rate_update_seconds in range [1, 60] seconds Coly Li
2018-02-01 21:44 ` Michael Lyle
2018-01-27 14:23 ` [PATCH v4 02/13] bcache: properly set task state in bch_writeback_thread() Coly Li
2018-02-01 21:45 ` Michael Lyle
2018-01-27 14:23 ` [PATCH v4 03/13] bcache: fix cached_dev->count usage for bch_cache_set_error() Coly Li
2018-01-27 14:23 ` [PATCH v4 04/13] bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set Coly Li
2018-01-27 14:23 ` [PATCH v4 05/13] bcache: stop dc->writeback_rate_update properly Coly Li
2018-01-27 14:23 ` [PATCH v4 06/13] bcache: set error_limit correctly Coly Li
2018-02-01 21:49 ` Michael Lyle [this message]
2018-01-27 14:24 ` [PATCH v4 07/13] bcache: add CACHE_SET_IO_DISABLE to struct cache_set flags Coly Li
2018-01-27 14:24 ` [PATCH v4 08/13] bcache: stop all attached bcache devices for a retired cache set Coly Li
2018-01-27 14:24 ` [PATCH v4 09/13] bcache: fix inaccurate io state for detached bcache devices Coly Li
2018-01-27 14:24 ` [PATCH v4 10/13] bcache: add backing_request_endio() for bi_end_io of attached backing device I/O Coly Li
2018-01-27 14:24 ` [PATCH v4 11/13] bcache: add io_disable to struct cached_dev Coly Li
2018-01-27 14:24 ` [PATCH v4 12/13] bcache: stop bcache device when backing device is offline Coly Li
2018-01-27 14:24 ` [PATCH v4 13/13] bcache: add stop_when_cache_set_failed to struct cached_dev Coly Li
2018-01-28 3:33 ` Pavel Goran
2018-01-28 4:32 ` Coly Li
2018-01-28 5:55 ` Re[2]: " Pavel Goran
2018-01-28 9:39 ` Coly Li
2018-01-29 12:57 ` Nix
2018-01-29 13:02 ` Coly Li
-- strict thread matches above, loose matches on Subject: below --
2018-01-28 1:56 [PATCH v4 00/13] bcache: device failure handling improvement Coly Li
2018-01-28 1:56 ` [PATCH v4 06/13] bcache: set error_limit correctly Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a809420e-c55c-d722-682a-9c8c38da45ee@lyle.org \
--to=mlyle@lyle.org \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=tang.junhui@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).