From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Borisov Subject: Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API Date: Wed, 9 Aug 2017 09:39:09 +0300 Message-ID: References: <1502095121-14337-1-git-send-email-byungchul.park@lge.com> <20170808041233.GR20323@X58A-UD3R> <20170808060056.GS20323@X58A-UD3R> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:47112 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750830AbdHIGjO (ORCPT ); Wed, 9 Aug 2017 02:39:14 -0400 In-Reply-To: <20170808060056.GS20323@X58A-UD3R> Content-Language: en-US Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Byungchul Park , Coly Li Cc: kent.overstreet@gmail.com, shli@kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@lge.com On 8.08.2017 09:00, Byungchul Park wrote: > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: >>>>> + llist_for_each_entry_safe(cl, t, reverse, list) { >>>> >>>> Just wondering why not using llist_for_each_entry(), or you use the >>>> _safe version on purpose ? >>> >>> If I use llist_for_each_entry(), then it would change the original >>> behavior. Is it ok? Generally, _safe versions of list primitives is used when you are going to perform removal in the iteration. I haven't looked at the code in bcache but if it's removing entries from the list then _safe version is required. If you are only iterating - then non-safe version is fine. >>> >> >> I feel llist_for_each_entry() keeps the original behavior, and variable > > Ah.. I see. Then.. Can I change it into non-safe version? Is it still ok > with non-safe one? I will change it at the next spin, if yes. > >> 't' can be removed. Anyway, either llist_for_each_entry() or >> llist_for_each_entry_safe() works correctly and well here. Any one you >> use is OK to me, thanks for your informative reply :-) > > I rather appriciate it. > > Thank you, > Byungchul >