From: Jiri Kosina <jikos@kernel.org>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
Maciej Piechotka <uzytkownik2@gmail.com>
Subject: Re: [PATCH] bcache: bch_writeback_thread() is not freezable
Date: Wed, 11 May 2016 09:55:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1605110954310.31937@cbobk.fhfr.pm> (raw)
In-Reply-To: <alpine.LRH.2.11.1605101812240.22680@mx.ewheeler.net>
On Tue, 10 May 2016, Eric Wheeler wrote:
> > > bch_writeback_thread() is calling try_to_freeze(), but that's just an
> > > expensive no-op given the fact that the thread is not marked freezable.
> > >
> > > I/O helper kthreads, exactly such as the bcache writeback thread, actually
> > > shouldn't be freezable, because they are potentially necessary for
> > > finalizing the image write-out.
> > >
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > Let's send a friendly ping on these three patches after two weeks...
>
> Maciej,
>
> Were you able to get a backtrace?
While I'd definitely like to understand the issues in interaction between
hibernation and bcache Maciej is supposedly seeing, this shouldn't hold
the application of the three patches in this series, as they are just a
cleanup that doesn't affect the behavior of the code in question.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-05-11 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 12:33 [PATCH] bcache: bch_writeback_thread() is not freezable Jiri Kosina
2016-04-19 12:34 ` [PATCH] bcache: bch_allocator_thread() " Jiri Kosina
2016-04-19 12:35 ` [PATCH] bcache: bch_gc_thread() " Jiri Kosina
2016-04-19 20:55 ` [PATCH] bcache: bch_writeback_thread() " Eric Wheeler
2016-04-19 22:25 ` Jiri Kosina
2016-04-22 1:19 ` Eric Wheeler
2016-04-25 8:19 ` Jiri Kosina
2016-05-02 7:16 ` Jiri Kosina
2016-05-11 1:13 ` Eric Wheeler
2016-05-11 7:55 ` Jiri Kosina [this message]
2016-05-18 15:28 ` Jiri Kosina
2016-05-23 23:05 ` Jiri Kosina
2016-05-24 14:18 ` Jens Axboe
2016-05-24 14:20 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1605110954310.31937@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=bcache@lists.ewheeler.net \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uzytkownik2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).