From: Jiri Kosina <jikos@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Eric Wheeler <bcache@lists.ewheeler.net>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] bcache: bch_gc_thread() is not freezable
Date: Tue, 24 May 2016 16:38:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1605241636220.31937@cbobk.fhfr.pm> (raw)
In-Reply-To: <alpine.LNX.2.00.1605241634270.31937@cbobk.fhfr.pm>
From: Jiri Kosina <jkosina@suse.cz>
bch_gc_thread() doesn't mark itself freezable, so calling try_to_freeze()
in its context is just an expensive no-op.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/md/bcache/btree.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 22b9e34..eab505e 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -27,7 +27,6 @@
#include <linux/slab.h>
#include <linux/bitops.h>
-#include <linux/freezer.h>
#include <linux/hash.h>
#include <linux/kthread.h>
#include <linux/prefetch.h>
@@ -1787,7 +1786,6 @@ again:
mutex_unlock(&c->bucket_lock);
- try_to_freeze();
schedule();
}
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2016-05-24 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:38 [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jiri Kosina
2016-05-24 14:38 ` [PATCH 2/4] bcache: bch_allocator_thread() " Jiri Kosina
2016-05-24 14:38 ` Jiri Kosina [this message]
2016-05-24 14:38 ` [PATCH 4/4] MAINTAINERS: mark bcache as orphan Jiri Kosina
2016-05-24 14:43 ` Joe Perches
2016-05-25 5:07 ` Jiri Kosina
2016-05-25 17:35 ` Jens Axboe
2016-05-24 15:01 ` [PATCH 1/4] bcache: bch_writeback_thread() is not freezable Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1605241636220.31937@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=axboe@kernel.dk \
--cc=bcache@lists.ewheeler.net \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).