From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Wheeler Subject: Re: [PATCH 3/3] bcache: Remove redundant block_size assignment Date: Tue, 10 May 2016 18:41:37 -0700 (PDT) Message-ID: References: <1462869529-11293-1-git-send-email-wangyijing@huawei.com> <1462869529-11293-3-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from [66.155.3.69] ([66.155.3.69]:57214 "EHLO mx.ewheeler.net" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcEKBl2 (ORCPT ); Tue, 10 May 2016 21:41:28 -0400 In-Reply-To: <1462869529-11293-3-git-send-email-wangyijing@huawei.com> Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Yijing Wang Cc: Kent Overstreet , linux-bcache@vger.kernel.org On Tue, 10 May 2016, Yijing Wang wrote: > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 1ccb9be..64d0be6 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -134,7 +134,6 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev, > case BCACHE_SB_VERSION_CDEV: > case BCACHE_SB_VERSION_CDEV_WITH_UUID: > sb->nbuckets = le64_to_cpu(s->nbuckets); > - sb->block_size = le16_to_cpu(s->block_size); > sb->bucket_size = le16_to_cpu(s->bucket_size); Are you sure we want to do that? The bcache superblock allows us to assign the block size presented by bcache and we wouldn't want 4k users to suddenly revert to 512b. -- Eric Wheeler > > sb->nr_in_set = le16_to_cpu(s->nr_in_set); > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >