From: Eric Wheeler <bcache@lists.ewheeler.net>
To: Michael Lyle <mlyle@lyle.org>
Cc: Coly Li <i@coly.li>, Liang Chen <liangchen.linux@gmail.com>,
linux-bcache@vger.kernel.org, kent.overstreet@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting
Date: Fri, 27 Oct 2017 19:05:45 +0000 (UTC) [thread overview]
Message-ID: <alpine.LRH.2.11.1710271903590.24585@mail.ewheeler.net> (raw)
In-Reply-To: <c06f2a04-3654-0bb9-f07d-ee6d2b27868d@lyle.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1274 bytes --]
On Tue, 10 Oct 2017, Michael Lyle wrote:
> On 10/10/2017 05:25 AM, Coly Li wrote:
> > On 2017/10/10 下午5:00, Liang Chen wrote:
> >> mutex_destroy does nothing most of time, but it's better to call
> >> it to make the code future proof and it also has some meaning
> >> for like mutex debug.
> >>
> >> As Coly pointed out in a previous review, bcache_exit() may not be
> >> able to handle all the references properly if userspace registers
> >> cache and backing devices right before bch_debug_init runs and
> >> bch_debug_init failes later. So not exposing userspace interface
> >> until everything is ready to avoid that issue.
> >>
> >> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
> >
> > Hi Liang,
> >
> > No more comment from me, it looks good. Thanks.
> >
> > Reviewed-by: Coly Li <colyli@suse.de>
>
> Looks good to me too.
>
> Reviewed-by: Michael Lyle <mlyle@lyle.org>
Should this Cc: stable to avoid the register race (possible
crash?) described by Liang in other stable kernels?
Reviewed-by: Eric Wheeler <bcache@linux.ewheeler.net>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-10-27 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 9:00 [PATCH v2] bcache: explicitly destroy mutex while exiting Liang Chen
2017-10-10 12:25 ` Coly Li
2017-10-10 15:44 ` Michael Lyle
2017-10-27 19:05 ` Eric Wheeler [this message]
2017-10-27 19:15 ` Michael Lyle
2017-10-30 12:33 ` Liang C
2017-10-30 18:02 ` Michael Lyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1710271903590.24585@mail.ewheeler.net \
--to=bcache@lists.ewheeler.net \
--cc=i@coly.li \
--cc=kent.overstreet@gmail.com \
--cc=liangchen.linux@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlyle@lyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox