From: Coly Li <colyli@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Eric Biggers <ebiggers3@gmail.com>,
Noah Massey <noah.massey@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-block@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Lyle <mlyle@lyle.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [PATCH v3 0/3] add crc64 calculation as kernel library
Date: Thu, 19 Jul 2018 10:45:55 +0800 [thread overview]
Message-ID: <bfbd0932-1bd1-7198-62e7-d920daa1bb58@suse.de> (raw)
In-Reply-To: <20180717145525.50852-1-colyli@suse.de>
On 2018/7/17 10:55 PM, Coly Li wrote:
> This patch set adds basic implementation of crc64 calculation as Linux
> kernel library. Since bcache already does crc64 by itself, this patch
> set also modifies bcache code to use the new crc64 library routine.
>
> bcache uses crc64 as storage checksum, if a change of crc lib routines
> results an inconsistent result, the unmatched checksum may make bcache
> 'think' the on-disk is corrupted, such change should be avoided or
> detected as early as possible. Therefore the last patch in this series
> adds a crc test framework, to check consistency of different calculations.
>
> Changelog:
> v3: Remove little endian restriction and remove 'le' from function names.
> Fixes all review comments of v2
> v2: Combine first two patches into one
> Fixes all review comments of v1
> v1: Initial version.
>
> Coly Li
Hi folks,
Many thanks for your review and comments, I do appreciate for your help.
Also thank Andrew to pick up the patches.
Coly Li
prev parent reply other threads:[~2018-07-19 2:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 14:55 [PATCH v3 0/3] add crc64 calculation as kernel library Coly Li
2018-07-17 14:55 ` [PATCH v3 1/3] lib: add crc64 calculation routines Coly Li
2018-07-17 15:43 ` Andy Shevchenko
2018-07-18 13:58 ` Coly Li
2018-07-17 16:31 ` Eric Biggers
2018-07-18 14:02 ` Coly Li
2018-07-24 13:33 ` David Laight
2018-07-17 14:55 ` [PATCH v3 2/3] bcache: use routines from lib/crc64.c for CRC64 calculation Coly Li
2018-07-17 15:44 ` Andy Shevchenko
2018-07-17 14:55 ` [PATCH v3 3/3] lib/test_crc: Add test cases for crc calculation Coly Li
2018-07-17 16:57 ` Randy Dunlap
2018-07-18 14:53 ` Coly Li
2018-07-17 17:11 ` Andy Shevchenko
2018-07-18 15:28 ` Coly Li
2018-07-17 18:51 ` Noah Massey
2018-07-17 20:59 ` Andy Shevchenko
2018-07-18 18:30 ` Noah Massey
2018-07-18 15:28 ` Coly Li
2018-07-17 15:46 ` [PATCH v3 0/3] add crc64 calculation as kernel library Andy Shevchenko
2018-07-19 2:45 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfbd0932-1bd1-7198-62e7-d920daa1bb58@suse.de \
--to=colyli@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ebiggers3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=noah.massey@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).