* [PATCH v1] md: Correct typos in multiple comments across various files
@ 2024-09-24 9:17 Shen Lichuan
2024-09-24 13:23 ` Mikulas Patocka
0 siblings, 1 reply; 5+ messages in thread
From: Shen Lichuan @ 2024-09-24 9:17 UTC (permalink / raw)
To: colyli, kent.overstreet, agk, snitzer, mpatocka, song
Cc: yukuai3, linux-bcache, linux-kernel, dm-devel, linux-raid,
Shen Lichuan
Fixed some confusing spelling errors that were currently identified,
the details are as follows:
-in the code comments:
writeback.c: 124: overrite ==> overwrite
dm-cache-target.c: 1371: exclussive ==> exclusive
dm-raid.c: 2522: repective ==> respective
md-cluster.c: 552: daemaon ==> daemon
md.c: 511: entred ==> entered
raid5-ppl.c: 990: parial ==> partial
Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
drivers/md/bcache/writeback.c | 2 +-
drivers/md/dm-cache-target.c | 2 +-
drivers/md/dm-raid.c | 2 +-
drivers/md/md-cluster.c | 2 +-
drivers/md/md.c | 2 +-
drivers/md/raid5-ppl.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index c1d28e365910..3354a5cd587c 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -121,7 +121,7 @@ static void __update_writeback_rate(struct cached_dev *dc)
}
fps = div_s64(dirty, dirty_buckets) * fp_term;
if (fragment > 3 && fps > proportional_scaled) {
- /* Only overrite the p when fragment > 3 */
+ /* Only overwrite the p when fragment > 3 */
proportional_scaled = fps;
}
}
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 17f0fab1e254..3e8be29c0a5e 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -1368,7 +1368,7 @@ static void mg_copy(struct work_struct *ws)
*/
bool rb = bio_detain_shared(mg->cache, mg->op->oblock, mg->overwrite_bio);
- BUG_ON(rb); /* An exclussive lock must _not_ be held for this block */
+ BUG_ON(rb); /* An exclusive lock must _not_ be held for this block */
mg->overwrite_bio = NULL;
inc_io_migrations(mg->cache);
mg_full_copy(ws);
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 63682d27fc8d..1e0d3b9b75d6 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2519,7 +2519,7 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
rdev->saved_raid_disk = rdev->raid_disk;
}
- /* Reshape support -> restore repective data offsets */
+ /* Reshape support -> restore respective data offsets */
rdev->data_offset = le64_to_cpu(sb->data_offset);
rdev->new_data_offset = le64_to_cpu(sb->new_data_offset);
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index 6595f89becdb..867af995b767 100644
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -549,7 +549,7 @@ static void process_metadata_update(struct mddev *mddev, struct cluster_msg *msg
dlm_lock_sync(cinfo->no_new_dev_lockres, DLM_LOCK_CR);
- /* daemaon thread must exist */
+ /* daemon thread must exist */
thread = rcu_dereference_protected(mddev->thread, true);
wait_event(thread->wqueue,
(got_lock = mddev_trylock(mddev)) ||
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 179ee4afe937..11078a4e4951 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -508,7 +508,7 @@ static void __mddev_resume(struct mddev *mddev, bool recovery_needed)
return;
}
- /* entred the memalloc scope from mddev_suspend() */
+ /* entered the memalloc scope from mddev_suspend() */
memalloc_noio_restore(mddev->noio_flag);
percpu_ref_resurrect(&mddev->active_io);
diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index a70cbec12ed0..5323025e7dd9 100644
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -987,7 +987,7 @@ static int ppl_recover(struct ppl_log *log, struct ppl_header *pplhdr,
crc = ~0;
crc_stored = le32_to_cpu(e->checksum);
- /* read parial parity for this entry and calculate its checksum */
+ /* read partial parity for this entry and calculate its checksum */
while (pp_size) {
int s = pp_size > PAGE_SIZE ? PAGE_SIZE : pp_size;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] md: Correct typos in multiple comments across various files
2024-09-24 9:17 [PATCH v1] md: Correct typos in multiple comments across various files Shen Lichuan
@ 2024-09-24 13:23 ` Mikulas Patocka
2024-09-24 21:24 ` Song Liu
0 siblings, 1 reply; 5+ messages in thread
From: Mikulas Patocka @ 2024-09-24 13:23 UTC (permalink / raw)
To: Shen Lichuan
Cc: colyli, kent.overstreet, agk, snitzer, song, yukuai3,
linux-bcache, linux-kernel, dm-devel, linux-raid
Hi
I've applied the device mapper part of the patch.
Mikulas
On Tue, 24 Sep 2024, Shen Lichuan wrote:
> Fixed some confusing spelling errors that were currently identified,
> the details are as follows:
>
> -in the code comments:
> writeback.c: 124: overrite ==> overwrite
> dm-cache-target.c: 1371: exclussive ==> exclusive
> dm-raid.c: 2522: repective ==> respective
> md-cluster.c: 552: daemaon ==> daemon
> md.c: 511: entred ==> entered
> raid5-ppl.c: 990: parial ==> partial
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> drivers/md/bcache/writeback.c | 2 +-
> drivers/md/dm-cache-target.c | 2 +-
> drivers/md/dm-raid.c | 2 +-
> drivers/md/md-cluster.c | 2 +-
> drivers/md/md.c | 2 +-
> drivers/md/raid5-ppl.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index c1d28e365910..3354a5cd587c 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -121,7 +121,7 @@ static void __update_writeback_rate(struct cached_dev *dc)
> }
> fps = div_s64(dirty, dirty_buckets) * fp_term;
> if (fragment > 3 && fps > proportional_scaled) {
> - /* Only overrite the p when fragment > 3 */
> + /* Only overwrite the p when fragment > 3 */
> proportional_scaled = fps;
> }
> }
> diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
> index 17f0fab1e254..3e8be29c0a5e 100644
> --- a/drivers/md/dm-cache-target.c
> +++ b/drivers/md/dm-cache-target.c
> @@ -1368,7 +1368,7 @@ static void mg_copy(struct work_struct *ws)
> */
> bool rb = bio_detain_shared(mg->cache, mg->op->oblock, mg->overwrite_bio);
>
> - BUG_ON(rb); /* An exclussive lock must _not_ be held for this block */
> + BUG_ON(rb); /* An exclusive lock must _not_ be held for this block */
> mg->overwrite_bio = NULL;
> inc_io_migrations(mg->cache);
> mg_full_copy(ws);
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 63682d27fc8d..1e0d3b9b75d6 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -2519,7 +2519,7 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
> rdev->saved_raid_disk = rdev->raid_disk;
> }
>
> - /* Reshape support -> restore repective data offsets */
> + /* Reshape support -> restore respective data offsets */
> rdev->data_offset = le64_to_cpu(sb->data_offset);
> rdev->new_data_offset = le64_to_cpu(sb->new_data_offset);
>
> diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
> index 6595f89becdb..867af995b767 100644
> --- a/drivers/md/md-cluster.c
> +++ b/drivers/md/md-cluster.c
> @@ -549,7 +549,7 @@ static void process_metadata_update(struct mddev *mddev, struct cluster_msg *msg
>
> dlm_lock_sync(cinfo->no_new_dev_lockres, DLM_LOCK_CR);
>
> - /* daemaon thread must exist */
> + /* daemon thread must exist */
> thread = rcu_dereference_protected(mddev->thread, true);
> wait_event(thread->wqueue,
> (got_lock = mddev_trylock(mddev)) ||
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 179ee4afe937..11078a4e4951 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -508,7 +508,7 @@ static void __mddev_resume(struct mddev *mddev, bool recovery_needed)
> return;
> }
>
> - /* entred the memalloc scope from mddev_suspend() */
> + /* entered the memalloc scope from mddev_suspend() */
> memalloc_noio_restore(mddev->noio_flag);
>
> percpu_ref_resurrect(&mddev->active_io);
> diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
> index a70cbec12ed0..5323025e7dd9 100644
> --- a/drivers/md/raid5-ppl.c
> +++ b/drivers/md/raid5-ppl.c
> @@ -987,7 +987,7 @@ static int ppl_recover(struct ppl_log *log, struct ppl_header *pplhdr,
> crc = ~0;
> crc_stored = le32_to_cpu(e->checksum);
>
> - /* read parial parity for this entry and calculate its checksum */
> + /* read partial parity for this entry and calculate its checksum */
> while (pp_size) {
> int s = pp_size > PAGE_SIZE ? PAGE_SIZE : pp_size;
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] md: Correct typos in multiple comments across various files
2024-09-24 13:23 ` Mikulas Patocka
@ 2024-09-24 21:24 ` Song Liu
2024-09-25 7:19 ` Coly Li
2024-09-25 9:05 ` Mikulas Patocka
0 siblings, 2 replies; 5+ messages in thread
From: Song Liu @ 2024-09-24 21:24 UTC (permalink / raw)
To: Mikulas Patocka
Cc: Shen Lichuan, colyli, kent.overstreet, agk, snitzer, yukuai3,
linux-bcache, linux-kernel, dm-devel, linux-raid
Hi Mikulas,
On Tue, Sep 24, 2024 at 6:30 AM Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> Hi
>
> I've applied the device mapper part of the patch.
Would you mind taking the whole patch instead? You can add
Acked-by: Song Liu <song@kernel.org>
Thanks,
Song
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] md: Correct typos in multiple comments across various files
2024-09-24 21:24 ` Song Liu
@ 2024-09-25 7:19 ` Coly Li
2024-09-25 9:05 ` Mikulas Patocka
1 sibling, 0 replies; 5+ messages in thread
From: Coly Li @ 2024-09-25 7:19 UTC (permalink / raw)
To: Song Liu, Mikulas Patocka
Cc: Shen Lichuan, Kent Overstreet, Alasdair Kergon, snitzer,
yukuai (C), Bcache Linux, Linux Kernel Mailing List, dm-devel,
Kernel.org-Linux-RAID
> 2024年9月25日 05:24，Song Liu <song@kernel.org> 写道：
>
> Hi Mikulas,
>
> On Tue, Sep 24, 2024 at 6:30 AM Mikulas Patocka <mpatocka@redhat.com> wrote:
>>
>> Hi
>>
>> I've applied the device mapper part of the patch.
>
> Would you mind taking the whole patch instead? You can add
>
> Acked-by: Song Liu <song@kernel.org>
Normally I don’t have interest for this type of patches, because it may introduce potential workload for downstream backport.
If this patch may go into upstream from other path, I don’t have objection neither. And if any comment wanted from me, I’d like to suggest to split this patch into multiple ones by different subsystem, it may be easier for downstream developers to do their backport.
Thanks.
Coly Li
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] md: Correct typos in multiple comments across various files
2024-09-24 21:24 ` Song Liu
2024-09-25 7:19 ` Coly Li
@ 2024-09-25 9:05 ` Mikulas Patocka
1 sibling, 0 replies; 5+ messages in thread
From: Mikulas Patocka @ 2024-09-25 9:05 UTC (permalink / raw)
To: Song Liu
Cc: Shen Lichuan, colyli, kent.overstreet, agk, snitzer, yukuai3,
linux-bcache, linux-kernel, dm-devel, linux-raid
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Tue, 24 Sep 2024, Song Liu wrote:
> Hi Mikulas,
>
> On Tue, Sep 24, 2024 at 6:30 AM Mikulas Patocka <mpatocka@redhat.com> wrote:
> >
> > Hi
> >
> > I've applied the device mapper part of the patch.
>
> Would you mind taking the whole patch instead? You can add
>
> Acked-by: Song Liu <song@kernel.org>
>
> Thanks,
> Song
I'm not a maintainer of MD and BCACHE. The MD and BCACHE part of the patch
should go through their tree.
Mikulas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-25 9:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 9:17 [PATCH v1] md: Correct typos in multiple comments across various files Shen Lichuan
2024-09-24 13:23 ` Mikulas Patocka
2024-09-24 21:24 ` Song Liu
2024-09-25 7:19 ` Coly Li
2024-09-25 9:05 ` Mikulas Patocka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).