From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3701F94D for ; Wed, 19 Jun 2024 14:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806880; cv=none; b=Exl9mYDslVVt04DCA2zTWmQ7r8gbQkcw33hibg46fJ3zzUUhe8eBxiqcu6qFNbPlEBOKo0fx6yMeHqXRKnLxJFD7EpkC6pz3ia8TKgFQsM5oDctQ138I/TPQPNOnCMJxTz6ExbTxm6FNEPCG+Qny1RHCj5UnfUHvG2b0YoQmkDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806880; c=relaxed/simple; bh=uH4XR4wLXeFFWwFyzqN4liYHhcQFiK7R5SRMOkCV9Yw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=ZZm66K+i41x2xnho5PmF07oci/Y42EtrkVE12JqgShcC3GJfQrjyhZozCXrCYqnby5km4z2rcuJObS+kl++XKPkz2Sgf9TU5cNi56UocD17HsPOJDC9cEpH7bdVtvic6emgX5/fcPfbWxBRCbcsqNwVcbj+00N/iseVWoKaKTjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=gN3m071S; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="gN3m071S" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-6c386a3ac43so406237a12.0 for ; Wed, 19 Jun 2024 07:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718806879; x=1719411679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=gN3m071SEtTl0OhquuEkIBzk+6An7z/TX2fEqSricgNWbByryugD5CB8h0u+FHwAGY QKbTdNi1JPAZEqPIe9tigW8BP8kweKQUS0L8IXja00/z+WqHW8ANBouOSBqqrS46mLB8 K22Q54/TLckKjn1PKxVrxH9x6n0jGs0TTApR9TDRp1kqPPPgmIywNnjOqZnuF0ahwGvr pnmbm/xtUeIQjYtpIwCZDcq3/PrNErg96816mmdo80e94xqeZuHy4PJIwlpX3UfpD1Gp lsHRzt0amLCOASe8+GW8iBS8m5PSyv/Hnft2tzaI3Gi9khyEjHeGu8Y1ozCbvEgcMijV /nEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718806879; x=1719411679; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrxAc+Uu30dWHZppC8CN0wQM7I31e2d3aLis3drkvvE=; b=DrACE4gtZS4oaTWST5JG8R4aA/OnkThk/X57vG1poeDTPj4sqkdeo8+Sl0aEVOk9OF XmGW3UEx2+nbz1QOTdFxU4EdULdQ4AOnNcNzc8vLkAfXtKvCERPgMgPLz/L464NiJsgf F1tGoun3kihPN07A18NPA3FWovznC4EP5rimEC/JEC8Syc/UWV32+4o0qKHUNelJYOGf 3i6OU0+k4dWKw993NLs/AVM0GipBiAMaopVQ4PzLMiDvMSxY9wWlpRTpUahGfh3bIuFx eJrBO33s1juZA9QJDRxpTLFfZKWzTNgsMuk6wpgvjvPVm3ELyYNWBOXHHR7Dgyzta/82 ohZg== X-Forwarded-Encrypted: i=1; AJvYcCUNeYv9AJQj97XKe85kHYcMNa7KrCfK48QtLop9zaHvKZELl2A20K1Jots1HyUZLE50szgLb9+sNYK3Xvpcht+vDI/r6HHR/roaKawF X-Gm-Message-State: AOJu0YzOrcfuePOA8UTyrIs6IfJnxMOlB/ogQaUV5y4earkcTpTPLCXW WKNh8oO6PgpEZszTLliynRPibeIC7eqIBvmkY1kXWrIh6Fcj+ks9gzlkaoGuqW4= X-Google-Smtp-Source: AGHT+IGlNYahWungPdY/VG0D2i+/kOzAqG/9vIEbq77BhnEO6pEhdeI5ihGxkaZBKQBmSE54SEc3pA== X-Received: by 2002:a05:6a21:33a5:b0:1b8:622a:cf7c with SMTP id adf61e73a8af0-1bcbb727134mr2697727637.3.1718806878609; Wed, 19 Jun 2024 07:21:18 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b110sm10739431b3a.153.2024.06.19.07.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 07:21:17 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 Precedence: bulk X-Mailing-List: linux-bcache@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig Cc: Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe