From: Jens Axboe <axboe@kernel.dk>
To: Michael Lyle <mlyle@lyle.org>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] bcache: writeback rate clamping: make 32 bit safe
Date: Mon, 16 Oct 2017 13:08:45 -0600 [thread overview]
Message-ID: <f0762144-33a7-abd5-8bf0-b5347c0aa799@kernel.dk> (raw)
In-Reply-To: <CAJ+L6qcdCDP=G4FUQphESad6zcSTExYp_6KP8jQSmb9Y9CB-3g@mail.gmail.com>
On 10/16/2017 01:07 PM, Michael Lyle wrote:
> Jens--
>
> Thanks for your patience.
>
> On Mon, Oct 16, 2017 at 12:01 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> On 10/16/2017 11:34 AM, Michael Lyle wrote:
>>> Sorry this got through to linux-block, was detected by the kbuilds test
>>> robot. NSEC_PER_SEC is a long constant; 2.5 * 10^9 doesn't fit in a
>>> signed long constant.
>>
>> Applied, but you should remember to add Fixes lines when a patch
>> explicitly fixes a problem introduced by a previous patch. Ala:
>>
>> Fixes: e41166c5c44e ("bcache: writeback rate shouldn't artifically clamp")
>>
>> so that backports have an easier time finding dependent fixes.
>
> Sorry about that too. I considered the Fixes: tag but didn't know if
> the hashes would "hold true" into mainline. Now I see Linus merges
> your tree so the hash should be durable.
They are durable once applied, so yeah.
--
Jens Axboe
prev parent reply other threads:[~2017-10-16 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 17:34 [PATCH] bcache: writeback rate clamping: make 32 bit safe Michael Lyle
2017-10-16 17:52 ` Coly Li
2017-10-16 19:01 ` Jens Axboe
2017-10-16 19:07 ` Michael Lyle
2017-10-16 19:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0762144-33a7-abd5-8bf0-b5347c0aa799@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox