From: Pavel Goran <via-bcache@pvgoran.name>
To: linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: fix uninterruptible sleep in writeback thread
Date: Sat, 17 May 2014 05:47:21 +0000 (UTC) [thread overview]
Message-ID: <loom.20140517T073846-450@post.gmane.org> (raw)
In-Reply-To: 1398981150-27765-1-git-send-email-sp@daterainc.com
Slava Pestov <sp <at> datera.io> writes:
> There were two issues here:
>
> - writeback thread did not start until the device first became dirty
> - writeback thread used uninterruptible sleep once running
>
> Without this patch I see kernel warnings printed and a load average of
> 1.52 after booting my test VM. With this patch the warnings are gone and
> the load average is near 0.00 as expected.
Uninterruptible sleep is indeed fixed (as well as the annoying "blocked for
more than 120 seconds" message), but with this patch, I have the following
problem. If I run a bcache device with no cache attached, the kernel hangs
when I try to reboot. It prints a long stack trace that takes all screen
space and I can't see what is above it.
If a cache is attached to the bcache device, rebooting works fine. Without
the patch, rebooting works both with and without attached cache.
prev parent reply other threads:[~2014-05-17 5:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 21:52 [PATCH] bcache: fix uninterruptible sleep in writeback thread Slava Pestov
2014-05-02 7:20 ` Daniel Smedegaard Buus
2014-05-02 8:10 ` Daniel Smedegaard Buus
2014-05-05 22:30 ` Nikolay Amiantov
2014-05-12 18:27 ` Peter Kieser
2014-05-15 8:02 ` Francis Moreau
2014-05-15 16:18 ` Peter Kieser
2014-05-15 17:29 ` Ross Anderson
2014-05-15 17:30 ` Jens Axboe
2014-06-02 14:07 ` Francis Moreau
2014-07-25 7:30 ` Francis Moreau
2014-09-05 7:08 ` Francis Moreau
2014-05-17 5:47 ` Pavel Goran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20140517T073846-450@post.gmane.org \
--to=via-bcache@pvgoran.name \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox