From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7252D1F7916 for ; Sat, 15 Mar 2025 17:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742060614; cv=none; b=sIuLtuX+wmbyoDdcdryxWfe4wcAfbcflKWU68AkRi8aGcQvRJf4FOfQDFAR2BChm6+1ar3S/ZoMfqsUZ+Qm4+eyW3hubhSTkiDUdHS1x2ZjSmC/r3ogvtgjhZVNp0szDJ2FrziaKuD2TIt2EuqtQTJLAV+4RbnR/R4OMKfA6pyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742060614; c=relaxed/simple; bh=8B7FabHqskcxfIkIahGna3Z/xLvt6pUmxe4pzSfQ70c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sLwxB42gPgF8TiplxAmH6nUXxMf391KKDS7HyX9BrZnHzcR1j0z27w+L8iH/tYVfK9+rvtoJAVFXB9g0fMUGFHaaS+Q4FjZH7pkTmZ4KN1DjHX5DSDaP4BUrJ343j8dXy0tMsiwFATMzMM0rH+gZsaUX1oB6FryytUWfy3EMVho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=UW8BkNu4; arc=none smtp.client-ip=209.85.166.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="UW8BkNu4" Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-85db3475637so104128439f.1 for ; Sat, 15 Mar 2025 10:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1742060611; x=1742665411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5mrlT3xIGjuTGv63EX5DNH3FIcnEnf1rv9hzQbUYWjQ=; b=UW8BkNu4y0if2VQ+24TBVgG+wlc/YZWIBHOC96ZITbMYWS6+DsZx1TQu82VVxa8rE4 SnnKkN6ki4mVEQ53AF6cBuOgzadlr7AyB8TE7zyC2vXiJAbFdjkzNno7iPKJiT7FUgru CZg4gCulIj1g64WKn2+3Lw2gqE/9y57AwqBj67au8qbEZ2W9j0gRsmX8X5i6qjmiCvbe LcON80KExO11FvLqMHztexsOjojdctLSmM3DNPMGU6gALHLQqnJxAk+0d+mh4xmB8Agg SEVTSEHFihmprMc1UJI8hRdZiK4QBXBwXDvh6fIWnt9lHxJ44dgsArtNjIU1Ttnh5kLu DScg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742060611; x=1742665411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mrlT3xIGjuTGv63EX5DNH3FIcnEnf1rv9hzQbUYWjQ=; b=ionhTjiiKDLAiQqxZ+c7d7S5wU5k7EQzHZwjo3cnnGSgTkmAoBv0hkaZIEFmA1Spzr GqvCjnBGOALmfG3heJ4ZFjvCybVD0c4IknXWAEkatwLt29KtqNzdFklly2nuGx176Ve2 EUZNe0LVuJfp8m3w6w8tu8sw4RqUSoWV4tY8iisaB8qk2xQvEeqQ3oW/YzxkjDr2KdaL mp6JOXD6XFFVsiNvLdxOJfCJiE4u06jTj9c9nN5RT4HtgWNKv/NVxv+iy/O/ajbCtUBk 8NKjbU2e4NX+lnrfXC6zk9sDxhqe9XLZr9wEWVyrXnTfZAsAYhH591x27HM8G6nGctbq XCDg== X-Gm-Message-State: AOJu0YyLu6f9iarVJmVjXVHqMEhUi5ISSamlsYAzqZn2uLfwYakIuzX5 Cg0u3LOkCJXAnS6eWBP+suFFYDNYVOH/ZPj9q2TiapEiUSqFjnpuPyu38kwSYNE= X-Gm-Gg: ASbGncviVLYh5nZVYoDSzrUE8UcuVYwj3SIzjCFHIkogBWNNyOGcawnbgR4ZYRLIOCP 6/FFTb2zSPIHnFeE7B3xy0wgYwKxk9ZFTGKlqdzj68R9upl495f9hYfZu1rofNVSMQArh+NNhd/ rtlRrUrfT4Fp5LlBGF+EFfqXH8KeMbuyjuF4OtNrFXcyrfmuH+N9Rgmq6K6+YzWPbsMhNAFD/yk mhQEbvmpYkCB+kJRwtxZ9/uEydi9LcRsut0Ahw2/MJ9gcFjnMDw3+VKZntF+oP/81MhNBZ/5Z11 d7tOfa6I0u+DWdF6wshmf61bj2i9N+4f0F0crbrxOw== X-Google-Smtp-Source: AGHT+IEvrtGFdMOgAMOedhiYVS9wcsNpV1fQGxb2LrV3O86HhTrXCjTOzbAFAobOS+dErlfsa/0DYQ== X-Received: by 2002:a92:dc4b:0:b0:3d4:346e:8d49 with SMTP id e9e14a558f8ab-3d47a022860mr98377385ab.9.1742060611501; Sat, 15 Mar 2025 10:43:31 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d47a67e5b3sm16154225ab.35.2025.03.15.10.43.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Mar 2025 10:43:30 -0700 (PDT) Message-ID: <0712e91f-2342-41ef-baad-3f2348f47ed6@kernel.dk> Date: Sat, 15 Mar 2025 11:43:30 -0600 Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/14] block: Allow REQ_FUA|REQ_READ To: Kent Overstreet Cc: linux-bcachefs@vger.kernel.org, linux-block@vger.kernel.org References: <20250311201518.3573009-1-kent.overstreet@linux.dev> <20250311201518.3573009-14-kent.overstreet@linux.dev> <9db17620-4b93-4c01-b7f8-ecab83b12d0f@kernel.dk> <510692e2-b83c-45bc-8d9d-08f7a172ffe6@kernel.dk> <5ymzmc3u3ar7p4do5xtrmlmddpzhkqse2gfharr3nrhvdexiiq@p3hszkhipbgr> Content-Language: en-US From: Jens Axboe In-Reply-To: <5ymzmc3u3ar7p4do5xtrmlmddpzhkqse2gfharr3nrhvdexiiq@p3hszkhipbgr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/15/25 11:27 AM, Kent Overstreet wrote: > On Sat, Mar 15, 2025 at 11:03:20AM -0600, Jens Axboe wrote: >> On 3/15/25 11:01 AM, Kent Overstreet wrote: >>> On Sat, Mar 15, 2025 at 10:47:09AM -0600, Jens Axboe wrote: >>>> On 3/11/25 2:15 PM, Kent Overstreet wrote: >>>>> REQ_FUA|REQ_READ means "do a read that bypasses the controller cache", >>>>> the same as writes. >>>>> >>>>> This is useful for when the filesystem gets a checksum error, it's >>>>> possible that a bit was flipped in the controller cache, and when we >>>>> retry we want to retry the entire IO, not just from cache. >>>>> >>>>> The nvme driver already passes through REQ_FUA for reads, not just >>>>> writes, so disabling the warning is sufficient to start using it, and >>>>> bcachefs is implementing additional retries for checksum errors so can >>>>> immediately use it. >>>> >>>> This one got effectively nak'ed by various folks here: >>>> >>>>> Link: https://lore.kernel.org/linux-block/20250311133517.3095878-1-kent.overstreet@linux.dev/ >>>> >>>> yet it's part of this series and in linux-next? Hmm? >>> >>> As I explained in that thread, they were only thinking about the caching >>> of writes. >>> >>> That's not what we're concerned about; when we retry a read due to a >>> checksum error we do not want the previous _read_ cached. >> >> Please follow the usual procedure of getting the patch acked/reviewed on >> the block list, and go through the usual trees. Until that happens, this >> patch should not be in your tree, not should it be staged in linux-next. > > It's been posted to linux-block and sent to your inbox. If you're going > to take it that's fine, otherwise - since this is necessary for handling > bitrotted data correctly and I've got users who've been waiting on this > patch series, and it's just deleting a warning, I'm inclined to just > send it. > > I'll make sure he's got the lore links and knows what's going on, but > this isn't a great thing to be delaying on citing process. Kent, you know how this works, there's nothing to argue about here. Let the block people get it reviewed and staged. You can't just post a patch, ignore most replies, and then go on to stage it yourself later that day. It didn't work well in other subsystems, and it won't work well here either. EOD on my end. -- Jens Axboe