linux-bcachefs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bcachefs-tools: make targets of subvolume create/delete required
@ 2024-11-09 10:57 Integral
  2024-12-09 17:56 ` Integral
  0 siblings, 1 reply; 2+ messages in thread
From: Integral @ 2024-11-09 10:57 UTC (permalink / raw)
  To: kent.overstreet, kent.overstreet, lihongbo22
  Cc: mmpgouride, linux-bcachefs, integral

Currently, when no targets are provided for "bcachefs subvolume create" or
"bcachefs subvolume delete", it will exit silently with code 0. Make targets
(arguments) required to solve this problem.

This patch solves issue https://github.com/koverstreet/bcachefs/issues/766.

Signed-off-by: Integral <integral@archlinuxcn.org>
---
 src/commands/subvolume.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/commands/subvolume.rs b/src/commands/subvolume.rs
index 7df20819..6f5f2f2b 100644
--- a/src/commands/subvolume.rs
+++ b/src/commands/subvolume.rs
@@ -18,12 +18,14 @@ enum Subcommands {
     #[command(visible_aliases = ["new"])]
     Create {
         /// Paths
+        #[arg(required = true)]
         targets: Vec<PathBuf>,
     },

     #[command(visible_aliases = ["del"])]
     Delete {
         /// Path
+        #[arg(required = true)]
         targets: Vec<PathBuf>,
     },

--
2.47.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-09 18:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-09 10:57 [PATCH] bcachefs-tools: make targets of subvolume create/delete required Integral
2024-12-09 17:56 ` Integral

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).