From: Chris Webb <chris@arachsys.com>
To: linux-bcachefs@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH] bcachefs: Return -ENOKEY/EINVAL when mount decryption fails
Date: Thu, 14 Oct 2021 13:52:43 +0100 [thread overview]
Message-ID: <20211014125243.GA9460@arachsys.com> (raw)
In-Reply-To: <20211014124016.GE11670@arachsys.com>
Chris Webb <chris@arachsys.com> writes:
> Return explicit error pointers out of bch2_fs_alloc() and handle them in
> both callers, so the user instead sees
Very happy to re-spin this in a different shape if you prefer to do anything
differently. I haven't split any other failure cases away from -ENOMEM in
this patch: most of them seem well-characterised as 'out of memory' anyway,
at least at first glance.
I did wonder about factoring the superblock decryption out of bch2_fs_alloc
completely rather than changing the NULL return code, but I think that's not
possible as later parts bch2_fs_alloc already require it to be unlocked?
> Signed-off-by: Chris Webb <chris@@arachsys.com>
*sigh* s/@@/@/ sorry!
Cheers,
Chris.
next prev parent reply other threads:[~2021-10-14 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 12:40 [PATCH] bcachefs: Return -ENOKEY/EINVAL when mount decryption fails Chris Webb
2021-10-14 12:52 ` Chris Webb [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-04 21:03 Chris Webb
2021-11-06 16:46 ` Kent Overstreet
2021-11-06 17:09 ` Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014125243.GA9460@arachsys.com \
--to=chris@arachsys.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox