public inbox for linux-bcachefs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-bcachefs@vger.kernel.org
Subject: [PATCH 0/2] bcachefs: checksum merge and writeback fix
Date: Wed, 27 Sep 2023 07:23:36 -0400	[thread overview]
Message-ID: <20230927112338.262207-1-bfoster@redhat.com> (raw)

Hi all,

A couple more small fixes. The first patch fixes a byte order problem in
the boundary code between bcachefs and the crc32c library related to
extent (and thus checksum) merges. The second patch addresses a small
logic wart that leads to more split writeback behavior than necessary,
which is how the problem addressed by patch 1 was observed. Patch 2 was
more of a "I'm not clear on why this size check is here, so let's try to
remove it and see what happens" patch. ;)

From chatting a bit in the meeting yesterday, I think we've already
established this isn't exactly what we want to do here. Instead, we
should still have some sort of bound on the size of a writeback op.
This is discussed a bit in the commit log description, but the consensus
seemed to be that this should just be replaced with a moderately less
conservative size check, such as 16MB or so. That's notably better than
the current limit of 1MB, so unless discussion on this patch leads in a
different direction, I'll probably follow up with a v2 to do that once
I've had a bit more chance to test it. Therefore, patch 2 is included
here mainly for posterity.

Thoughts, reviews, flames appreciated.

Brian

Brian Foster (2):
  bcachefs: fix crc32c checksum merge byte order problem
  bcachefs: remove writeback bio size limit

 fs/bcachefs/checksum.c       | 4 ++--
 fs/bcachefs/fs-io-buffered.c | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-27 11:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 11:23 Brian Foster [this message]
2023-09-27 11:23 ` [PATCH 1/2] bcachefs: fix crc32c checksum merge byte order problem Brian Foster
2023-09-27 22:08   ` Kent Overstreet
2023-09-28 14:12     ` Brian Foster
2023-09-28 16:57       ` Kent Overstreet
2023-09-29  8:13         ` Janpieter Sollie
2023-09-27 11:23 ` [PATCH 2/2] bcachefs: remove writeback bio size limit Brian Foster
2023-09-27 22:03   ` Kent Overstreet
2023-09-29 14:31     ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927112338.262207-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-bcachefs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox