From: Kent Overstreet <kent.overstreet@linux.dev>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH] bcachefs: update alloc cursor in early bucket allocator
Date: Thu, 19 Oct 2023 14:38:03 -0400 [thread overview]
Message-ID: <20231019183803.njsjs4sz7p4zpyfc@moria.home.lan> (raw)
In-Reply-To: <ZTFl3jJJi2CoDdJB@bfoster>
On Thu, Oct 19, 2023 at 01:22:38PM -0400, Brian Foster wrote:
> BTW, should this code be protected from no free space situations at a
> higher level, or should we consider a max retry count or something? I
> want to be cautious about things like prospective livelocks
> (particularly if this path is less common) if this retry was effectively
> dead code due to not updating alloc_cursor.
It should be limiting itself to a single retry already: on retry, we set
alloc_cursor = alloc_start, so we won't retry again. Just make sure that
still works :)
next prev parent reply other threads:[~2023-10-19 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:27 [PATCH] bcachefs: update alloc cursor in early bucket allocator Brian Foster
2023-10-19 15:30 ` Kent Overstreet
2023-10-19 17:22 ` Brian Foster
2023-10-19 18:38 ` Kent Overstreet [this message]
2023-10-20 16:01 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019183803.njsjs4sz7p4zpyfc@moria.home.lan \
--to=kent.overstreet@linux.dev \
--cc=bfoster@redhat.com \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox