From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B45250E8; Wed, 17 Jan 2024 20:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705524835; cv=none; b=jXVVYrcyKMEV3MmfdEO6s9Gv12Ick9+yrJItxG5hRbVgXNqS6NY8Q9phKScvVvg469KrqsRR6KqEI3YjOrHULCqN1aKjt32rAKNwu6GD9/F4UDMQQP8FcUk3QPTj9zvWzGwxwhR+PUkr6fUzlRwcDmAxht28OSs9/QFdWZ24W0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705524835; c=relaxed/simple; bh=nfzBUFpTVfYKkbNTgb1Nmnf+ekQoGuqr3FfY04uP1JA=; h=Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Date:From:To:Cc:Subject: Message-ID:Reply-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Spamd-Result:X-Rspamd-Server: X-Rspamd-Queue-Id:X-Spam-Level:X-Spam-Score:X-Spam-Flag; b=IV0b61q6Gwq+GosWZulu6biWN9aASZ70O3/5YUMO8MvUiDEqxASIklm4lM2kk/aNLUuYkrWE/++9aYJMooZT9nxoZIsSvLpHA2KmmyzZwAjNHOZGvxAFFtxe1K/8frKSCqRsS1qi3eBG9wEJlW0ydg7qngA204cKZIud3Jrflt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=j3TMmmRi; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=HIvEexuf; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=j3TMmmRi; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=HIvEexuf; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="j3TMmmRi"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="HIvEexuf"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="j3TMmmRi"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="HIvEexuf" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45EFE1F391; Wed, 17 Jan 2024 20:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705524831; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRDIiDroMCvM69s3QA+b2XVfeJo5GJLdEPsAEzVMC9A=; b=j3TMmmRinPI7VxLym2fwWzEj/ZDx/e3AWDi4HRzMhq0+V6y3MVW2cjnqHTgQsKEw/xx44r dBteypt+Vpy1LIRQfVtdniX4bq1/ELDdMzTdO5BUVsKiXgvohiV6SfaxWFKhmD8djYTQCw KfD4CVT2ayfNi0oYtwG7e/5VkmNFI/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705524831; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRDIiDroMCvM69s3QA+b2XVfeJo5GJLdEPsAEzVMC9A=; b=HIvEexufSLffz9AB+a616MxNd6OwtSLJnwNZ8vH3Rdkbjd62p0430p73x3tteL/mNPazKZ Fu8iMlsiKp3YQHDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705524831; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRDIiDroMCvM69s3QA+b2XVfeJo5GJLdEPsAEzVMC9A=; b=j3TMmmRinPI7VxLym2fwWzEj/ZDx/e3AWDi4HRzMhq0+V6y3MVW2cjnqHTgQsKEw/xx44r dBteypt+Vpy1LIRQfVtdniX4bq1/ELDdMzTdO5BUVsKiXgvohiV6SfaxWFKhmD8djYTQCw KfD4CVT2ayfNi0oYtwG7e/5VkmNFI/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705524831; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRDIiDroMCvM69s3QA+b2XVfeJo5GJLdEPsAEzVMC9A=; b=HIvEexufSLffz9AB+a616MxNd6OwtSLJnwNZ8vH3Rdkbjd62p0430p73x3tteL/mNPazKZ Fu8iMlsiKp3YQHDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A857513751; Wed, 17 Jan 2024 20:53:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3pGIJV4+qGX1egAAD6G6ig (envelope-from ); Wed, 17 Jan 2024 20:53:50 +0000 Date: Wed, 17 Jan 2024 21:53:48 +0100 From: Petr Vorel To: Cyril Hrubis Cc: ltp@lists.linux.it, Li Wang , Jan Stancek , Xiao Yang , Yang Xu , Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 1/1] safe_macros: Fix bcachefs failure old kernel Message-ID: <20240117205348.GB2723246@pevik> Reply-To: Petr Vorel References: <20240111150553.1923767-1-pvorel@suse.cz> Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j3TMmmRi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HIvEexuf X-Spamd-Result: default: False [-2.51 / 50.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[10]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 45EFE1F391 X-Spam-Level: X-Spam-Score: -2.51 X-Spam-Flag: NO > Hi! > > I'm sorry, although man bcachefs(8) mentions fusemount, I haven't > > figured out how to mount filesystem. Am I missing something? > > Also, maybe for the start I would prefer to to test just kernel > > functionality (no fuse). > So this means that mount.bcasefs does exist, but the mount() fails? That > sounds like something wasn't wired up properly. Yes, mount.bcasefs exists, at least on openSUSE Tumbleweed (I suppose elsewhere as well). Everything is done by single binary bcachefs. ls -la /sbin/* |grep bcachefs -rwxr-xr-x 1 root root 1424080 Jan 9 15:00 /sbin/bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/fsck.bcachefs -> bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/fsck.fuse.bcachefs -> bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/mkfs.bcachefs -> bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/mkfs.fuse.bcachefs -> bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/mount.bcachefs -> bcachefs lrwxrwxrwx 1 root root 8 Jan 9 15:00 /sbin/mount.fuse.bcachefs -> bcachefs > > Kind regards, > > Petr > > lib/tst_supported_fs_types.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c > > index 369836717..21765c370 100644 > > --- a/lib/tst_supported_fs_types.c > > +++ b/lib/tst_supported_fs_types.c > > @@ -96,6 +96,11 @@ static enum tst_fs_impl has_kernel_support(const char *fs_type) > > SAFE_RMDIR(template); > > + if (!strcmp(fs_type, "bcachefs") && tst_kvercmp(6, 7, 0) < 0) { > > + tst_res(TINFO, "bcachefs skipped on kernel < 6.7"); > > + return TST_FS_UNSUPPORTED; > > + } > I would rather turn this into a FUSE specific blacklist without a kernel > version, since bcachefs got into the kernel I do not think the fuse > version would be useful for testhing at all, so what about: Your code makes sense, I'll test it. Kind regards, Petr > diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c > index 369836717..4110c826e 100644 > --- a/lib/tst_supported_fs_types.c > +++ b/lib/tst_supported_fs_types.c > @@ -33,6 +33,11 @@ static const char *const fs_type_whitelist[] = { > NULL > }; > +static const cahr *const fs_type_fuse_blacklist[] = { > + "bcachefs", > + NULL, > +}; > + > static const char *fs_types[ARRAY_SIZE(fs_type_whitelist)]; > static int has_mkfs(const char *fs_type) > @@ -96,6 +101,11 @@ static enum tst_fs_impl has_kernel_support(const char *fs_type) > SAFE_RMDIR(template); > + if (tst_fs_in_skiplist(fs_type, tst_fs_type_fuse_blacklist)) { > + tst_res("Skipping %s because of FUSE blacklist", fs_type); > + return TST_FS_UNSUPPORTED; > + } > + > /* Is FUSE supported by kernel? */ > if (fuse_supported == -1) { > ret = open("/dev/fuse", O_RDWR); > > /* Is FUSE supported by kernel? */ > > if (fuse_supported == -1) { > > ret = open("/dev/fuse", O_RDWR);